[data] disable image_embedding_from_jsonl_fixed_size_chaos #57544
Conversation
… frequency cherypick #57273 Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
Thank you for this contribution. The change to disable the image_embedding_from_jsonl_fixed_size_chaos test by setting its frequency to manual is well-justified, given that it's expected to time out. I have one suggestion to improve the maintainability of the YAML configuration by reducing redundancy. Please see my detailed comment.
|
|
||
| - name: image_embedding_from_jsonl_{{case}} | ||
| frequency: weekly | ||
| frequency: "{{frequency}}" |
There was a problem hiding this comment.
To reduce redundancy and improve maintainability, consider using a default value for frequency. If the templating engine supports Jinja2-style filters, you can use the default filter here.
This would make weekly the default frequency, allowing you to remove the explicit frequency: weekly declarations on lines 582 and 587 for the fixed_size and autoscaling cases. The configuration becomes cleaner as you only need to specify the frequency when it deviates from the default.
frequency: "{{ frequency | default('weekly') }}"
cherypick #57273
The
image_embedding_from_jsonl_fixed_size_chaosrelease test runs a large image embedding workload with a preemption every minute. Since this test features long-running tasks and frequent preemptions, it's expected to time out (it's not a regression). So, this PR changes the frequency to manual.