[Data] Make image_embedding_from_jsonl_fixed_size_chaos run on manual frequency
#57273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to change the execution frequency of the image_embedding_from_jsonl_fixed_size_chaos test to manual because it consistently times out. The approach of parameterizing the frequency and setting it per test case in the matrix is correct. However, the implementation has a small issue that will cause test parsing to fail. I've left a comment with details on how to fix it. Once that's addressed, this change should work as intended.
aslonnie
approved these changes
Oct 7, 2025
aslonnie
added a commit
that referenced
this pull request
Oct 8, 2025
… frequency cherypick #57273 Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
aslonnie
added a commit
that referenced
this pull request
Oct 8, 2025
cherypick #57273 The `image_embedding_from_jsonl_fixed_size_chaos` release test runs a large image embedding workload with a preemption every minute. Since this test features long-running tasks and frequent preemptions, it's expected to time out (it's not a regression). So, this PR changes the frequency to manual. Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
liulehui
pushed a commit
to liulehui/ray
that referenced
this pull request
Oct 9, 2025
…al frequency (ray-project#57273) The `image_embedding_from_jsonl_fixed_size_chaos` release test runs a large image embedding workload with a preemption every minute. Since this test features long-running tasks and frequent preemptions, it's expected to time out (it's not a regression). So, this PR changes the frequency to manual. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
joshkodi
pushed a commit
to joshkodi/ray
that referenced
this pull request
Oct 13, 2025
…al frequency (ray-project#57273) The `image_embedding_from_jsonl_fixed_size_chaos` release test runs a large image embedding workload with a preemption every minute. Since this test features long-running tasks and frequent preemptions, it's expected to time out (it's not a regression). So, this PR changes the frequency to manual. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: Josh Kodi <joshkodi@gmail.com>
justinyeh1995
pushed a commit
to justinyeh1995/ray
that referenced
this pull request
Oct 20, 2025
…al frequency (ray-project#57273) The `image_embedding_from_jsonl_fixed_size_chaos` release test runs a large image embedding workload with a preemption every minute. Since this test features long-running tasks and frequent preemptions, it's expected to time out (it's not a regression). So, this PR changes the frequency to manual. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
xinyuangui2
pushed a commit
to xinyuangui2/ray
that referenced
this pull request
Oct 22, 2025
…al frequency (ray-project#57273) The `image_embedding_from_jsonl_fixed_size_chaos` release test runs a large image embedding workload with a preemption every minute. Since this test features long-running tasks and frequent preemptions, it's expected to time out (it's not a regression). So, this PR changes the frequency to manual. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: xgui <xgui@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…al frequency (ray-project#57273) The `image_embedding_from_jsonl_fixed_size_chaos` release test runs a large image embedding workload with a preemption every minute. Since this test features long-running tasks and frequent preemptions, it's expected to time out (it's not a regression). So, this PR changes the frequency to manual. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
…al frequency (ray-project#57273) The `image_embedding_from_jsonl_fixed_size_chaos` release test runs a large image embedding workload with a preemption every minute. Since this test features long-running tasks and frequent preemptions, it's expected to time out (it's not a regression). So, this PR changes the frequency to manual. --------- Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The
image_embedding_from_jsonl_fixed_size_chaosrelease test runs a large image embedding workload with a preemption every minute. Since this test features long-running tasks and frequent preemptions, it's expected to time out (it's not a regression). So, this PR changes the frequency to manual.Related issue number
Checks
git commit -s) in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.