Skip to content

[data] disable image_embedding_from_jsonl_fixed_size_chaos #57544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2025
Merged

[data] disable image_embedding_from_jsonl_fixed_size_chaos #57544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion release/release_data_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,27 +565,33 @@


- name: image_embedding_from_jsonl_{{case}}
frequency: weekly
frequency: "{{frequency}}"
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To reduce redundancy and improve maintainability, consider using a default value for frequency. If the templating engine supports Jinja2-style filters, you can use the default filter here.

This would make weekly the default frequency, allowing you to remove the explicit frequency: weekly declarations on lines 582 and 587 for the fixed_size and autoscaling cases. The configuration becomes cleaner as you only need to specify the frequency when it deviates from the default.

  frequency: "{{ frequency | default('weekly') }}"

group: data-batch-inference

matrix:
setup:
case: []
cluster_type: []
args: []
frequency: []
adjustments:
- with:
case: fixed_size
cluster_type: fixed_size
args: --inference-concurrency 40 40
frequency: weekly
- with:
case: autoscaling
cluster_type: autoscaling
args: --inference-concurrency 1 40
frequency: weekly
- with:
case: fixed_size_chaos
cluster_type: fixed_size
args: --inference-concurrency 40 40 --chaos
# This release test is run on a 'manual' frequency because it's expected to
# fail.
frequency: manual

cluster:
cluster_compute: image_embedding_from_jsonl/{{cluster_type}}_cluster_compute.yaml
Expand Down