Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort includes #683

Merged
merged 1 commit into from
May 20, 2020
Merged

sort includes #683

merged 1 commit into from
May 20, 2020

Conversation

rwalker-apple
Copy link
Contributor

Problem

CHIP would like to have sorted include blocks

Summary of Changes

updates .clang-format

fixes #116

gerickson
gerickson approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@gerickson gerickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this maintain subsystem groupings and handle conditionals around includes?

@rwalker-apple
Copy link
Contributor Author

if it doesn't I'll revert

I'm trying this out. If this is unenforceable with clang-format, we'll have to be pendantic in reviews.

@rwalker-apple rwalker-apple mentioned this pull request May 13, 2020
Merged
This was referenced May 13, 2020
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced May 14, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@woody-apple
Copy link
Contributor

@rwalker-apple is this complete now?

@rwalker-apple rwalker-apple changed the title WIP: sort includes sort includes May 19, 2020
@rwalker-apple rwalker-apple marked this pull request as ready for review May 19, 2020 22:34
@rwalker-apple
Copy link
Contributor Author

most of the tree is set correctly now, this can land without major disruption

@rwalker-apple
Copy link
Contributor Author

@saurabhst @hawk248 @BroderickCarlin @jelderton ?

@woody-apple woody-apple merged commit dc264b1 into project-chip:master May 20, 2020
@rwalker-apple rwalker-apple deleted the sort-includes branch May 20, 2020 03:22
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request May 2, 2023
@silabs-srishylam @jmartinez-silabs
Pull request project-chip#683: Latest WiseMCU package version 1.0.1.8
c42e30f 
Merge in WMN_TOOLS/matter from feature/wifi_917_adding_latest_wiseMCU to silabs

Squashed commit of the following:

commit 6efc5fc94e0a5d94ad3d9e2002ff1b24b12d9f9d
Author: srningap <Srishylam.Ningapuram@silabs.com>
Date:   Wed Apr 5 11:16:55 2023 +0530

    reverted LEDWidget.h file change

commit 12b20ccaafa51a3fdbaea7967695cfbf35e8ec23
Author: srningap <Srishylam.Ningapuram@silabs.com>
Date:   Tue Apr 4 17:20:00 2023 +0530

    Adds latest WiseMCU package version 1.0.1.8
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Oct 5, 2023
@silabs-srishylam @jmartinez-silabs
Pull request project-chip#683: Latest WiseMCU package version 1.0.1.8
34663d8 
Merge in WMN_TOOLS/matter from feature/wifi_917_adding_latest_wiseMCU to silabs

Squashed commit of the following:

commit 6efc5fc94e0a5d94ad3d9e2002ff1b24b12d9f9d
Author: srningap <Srishylam.Ningapuram@silabs.com>
Date:   Wed Apr 5 11:16:55 2023 +0530

    reverted LEDWidget.h file change

commit 12b20ccaafa51a3fdbaea7967695cfbf35e8ec23
Author: srningap <Srishylam.Ningapuram@silabs.com>
Date:   Tue Apr 4 17:20:00 2023 +0530

    Adds latest WiseMCU package version 1.0.1.8
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Jan 11, 2024
@silabs-srishylam @jmartinez-silabs
Pull request project-chip#683: Latest WiseMCU package version 1.0.1.8
dc9de29 
Merge in WMN_TOOLS/matter from feature/wifi_917_adding_latest_wiseMCU to silabs

Squashed commit of the following:

commit 6efc5fc94e0a5d94ad3d9e2002ff1b24b12d9f9d
Author: srningap <Srishylam.Ningapuram@silabs.com>
Date:   Wed Apr 5 11:16:55 2023 +0530

    reverted LEDWidget.h file change

commit 12b20ccaafa51a3fdbaea7967695cfbf35e8ec23
Author: srningap <Srishylam.Ningapuram@silabs.com>
Date:   Tue Apr 4 17:20:00 2023 +0530

    Adds latest WiseMCU package version 1.0.1.8
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jan 29, 2024
@silabs-srishylam @jmartinez-silabs
Pull request project-chip#683: Latest WiseMCU package version 1.0.1.8
d4abb4e 
Merge in WMN_TOOLS/matter from feature/wifi_917_adding_latest_wiseMCU to silabs

Squashed commit of the following:

commit 6efc5fc94e0a5d94ad3d9e2002ff1b24b12d9f9d
Author: srningap <Srishylam.Ningapuram@silabs.com>
Date:   Wed Apr 5 11:16:55 2023 +0530

    reverted LEDWidget.h file change

commit 12b20ccaafa51a3fdbaea7967695cfbf35e8ec23
Author: srningap <Srishylam.Ningapuram@silabs.com>
Date:   Tue Apr 4 17:20:00 2023 +0530

    Adds latest WiseMCU package version 1.0.1.8
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jan 29, 2024
@silabs-srishylam @jmartinez-silabs
Pull request project-chip#683: Latest WiseMCU package version 1.0.1.8
ad1d150 
Merge in WMN_TOOLS/matter from feature/wifi_917_adding_latest_wiseMCU to silabs

Squashed commit of the following:

commit 6efc5fc94e0a5d94ad3d9e2002ff1b24b12d9f9d
Author: srningap <Srishylam.Ningapuram@silabs.com>
Date:   Wed Apr 5 11:16:55 2023 +0530

    reverted LEDWidget.h file change

commit 12b20ccaafa51a3fdbaea7967695cfbf35e8ec23
Author: srningap <Srishylam.Ningapuram@silabs.com>
Date:   Tue Apr 4 17:20:00 2023 +0530

    Adds latest WiseMCU package version 1.0.1.8
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
@silabs-srishylam @jmartinez-silabs
Pull request project-chip#683: Latest WiseMCU package version 1.0.1.8
51db8cf 
Merge in WMN_TOOLS/matter from feature/wifi_917_adding_latest_wiseMCU to silabs

Squashed commit of the following:

commit 6efc5fc94e0a5d94ad3d9e2002ff1b24b12d9f9d
Author: srningap <Srishylam.Ningapuram@silabs.com>
Date:   Wed Apr 5 11:16:55 2023 +0530

    reverted LEDWidget.h file change

commit 12b20ccaafa51a3fdbaea7967695cfbf35e8ec23
Author: srningap <Srishylam.Ningapuram@silabs.com>
Date:   Tue Apr 4 17:20:00 2023 +0530

    Adds latest WiseMCU package version 1.0.1.8
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
@silabs-srishylam @jmartinez-silabs
Pull request project-chip#683: Latest WiseMCU package version 1.0.1.8
26da9fa 
Merge in WMN_TOOLS/matter from feature/wifi_917_adding_latest_wiseMCU to silabs

Squashed commit of the following:

commit 6efc5fc94e0a5d94ad3d9e2002ff1b24b12d9f9d
Author: srningap <Srishylam.Ningapuram@silabs.com>
Date:   Wed Apr 5 11:16:55 2023 +0530

    reverted LEDWidget.h file change

commit 12b20ccaafa51a3fdbaea7967695cfbf35e8ec23
Author: srningap <Srishylam.Ningapuram@silabs.com>
Date:   Tue Apr 4 17:20:00 2023 +0530

    Adds latest WiseMCU package version 1.0.1.8
chirag-silabs pushed a commit to rosahay-silabs/connectedhomeip that referenced this pull request Jul 15, 2024
@silabs-srishylam @jmartinez-silabs
Pull request project-chip#683: Latest WiseMCU package version 1.0.1.8
56cc4da 
Merge in WMN_TOOLS/matter from feature/wifi_917_adding_latest_wiseMCU to silabs

Squashed commit of the following:

commit 6efc5fc94e0a5d94ad3d9e2002ff1b24b12d9f9d
Author: srningap <Srishylam.Ningapuram@silabs.com>
Date:   Wed Apr 5 11:16:55 2023 +0530

    reverted LEDWidget.h file change

commit 12b20ccaafa51a3fdbaea7967695cfbf35e8ec23
Author: srningap <Srishylam.Ningapuram@silabs.com>
Date:   Tue Apr 4 17:20:00 2023 +0530

    Adds latest WiseMCU package version 1.0.1.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerickson gerickson gerickson approved these changes

@saurabhst saurabhst saurabhst approved these changes

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@BroderickCarlin BroderickCarlin Awaiting requested review from BroderickCarlin

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rwalker-apple @woody-apple @gerickson @saurabhst