Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort includes system #715

Merged
merged 1 commit into from
May 14, 2020

Conversation

rwalker-apple
Copy link
Contributor

Problem

includes aren't sorted

Summary of Changes

  • sort includes
  • make blocks
  • other small grooming

working on #116, part of #683

@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #715 into master will decrease coverage by 2.93%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #715      +/-   ##
==========================================
- Coverage   60.18%   57.25%   -2.94%     
==========================================
  Files         130      130              
  Lines       12670    12650      -20     
==========================================
- Hits         7626     7243     -383     
- Misses       5044     5407     +363     
Impacted Files Coverage Δ
src/system/SystemClock.cpp 20.68% <ø> (ø)
src/system/SystemError.cpp 8.16% <ø> (-61.23%) ⬇️
src/system/SystemFaultInjection.cpp 31.81% <ø> (-18.19%) ⬇️
src/system/SystemLayer.cpp 55.47% <ø> (ø)
src/system/SystemLayer.h 100.00% <ø> (ø)
src/system/SystemMutex.h 100.00% <ø> (ø)
src/system/SystemObject.cpp 93.75% <ø> (ø)
src/system/SystemPacketBuffer.cpp 96.04% <ø> (-1.13%) ⬇️
src/system/SystemPacketBuffer.h 100.00% <ø> (ø)
src/system/SystemTimer.cpp 4.65% <ø> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c4babc...c50b54b. Read the comment docs.

@woody-apple woody-apple merged commit d0789c9 into project-chip:master May 14, 2020
@rwalker-apple rwalker-apple deleted the sort-includes-system branch May 15, 2020 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants