-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reorder headers and break into blocks in src/app #685
reorder headers and break into blocks in src/app #685
Conversation
06cc294
to
1de3ba4
Compare
1de3ba4
to
9b13c6c
Compare
@wehale @tecimovic would you have a look? the changes are grouping headers by sorting blocks, where necessary to get the code compiling with sorted include directives |
@rwalker-apple : the header sorting and cleanup is a worthy exercise, but the entire src/app is nowhere near the state where this really matters at this point. I think we'll break down the headers some more, separate the APIs into upward looking ones (callbacks) and downward looking ones (API propers), and most of all, deal with the includes for the generated stuff, which should in the final solution not be #included in, but linked in. |
@rwalker-apple : one more thing: I see your diffs are operating on a directory structure as it was before the PR that I'm having in the queue now. There will be an annoying merge conflict either way, so I think at this point, getting a PR in that touches files in the old directory structure, will just cause a nightmare of a merge. |
this is to forestall future issues when auto-formatting starts enforcing this |
I have a lot of experience fixing up merges, can help. |
Problem
includes aren't sorted
Summary of Changes
working on #116, part of #683