reorder headers and break into blocks in src/app

[rwalker-apple]

Problem

includes aren't sorted

Summary of Changes

• sort includes
• break into blocks for things that shouldn't be sorted (e.g. gen-* headers aren't stand-alone, need to have zcl stuff before them)
• make more headers stand alone

working on #116, part of #683

[rwalker-apple]

@wehale @tecimovic would you have a look?

the changes are grouping headers by sorting blocks, where necessary to get the code compiling with sorted include directives

[tecimovic]

@rwalker-apple : the header sorting and cleanup is a worthy exercise, but the entire src/app is nowhere near the state where this really matters at this point. I think we'll break down the headers some more, separate the APIs into upward looking ones (callbacks) and downward looking ones (API propers), and most of all, deal with the includes for the generated stuff, which should in the final solution not be #included in, but linked in.

[tecimovic]

@rwalker-apple : one more thing: I see your diffs are operating on a directory structure as it was before the PR that I'm having in the queue now.

There will be an annoying merge conflict either way, so I think at this point, getting a PR in that touches files in the old directory structure, will just cause a nightmare of a merge.

[rwalker-apple]

@rwalker-apple : the header sorting and cleanup is a worthy exercise, but the entire src/app is nowhere near the state where this really matters at this point. I think we'll break down the headers some more, separate the APIs into upward looking ones (callbacks) and downward looking ones (API propers), and most of all, deal with the includes for the generated stuff, which should in the final solution not be #included in, but linked in.

this is to forestall future issues when auto-formatting starts enforcing this

[rwalker-apple]

@BroderickCarlin @woody-apple ?

[rwalker-apple]

@rwalker-apple : one more thing: I see your diffs are operating on a directory structure as it was before the PR that I'm having in the queue now.

There will be an annoying merge conflict either way, so I think at this point, getting a PR in that touches files in the old directory structure, will just cause a nightmare of a merge.

I have a lot of experience fixing up merges, can help.

[rwalker-apple]

@hawk248 @saurabhst @jelderton ?

[rwalker-apple]

@BroderickCarlin