Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort includes CHIP_Framework_iOS #717

Merged
merged 1 commit into from
May 15, 2020
Merged

sort includes CHIP_Framework_iOS #717

merged 1 commit into from
May 15, 2020

Conversation

rwalker-apple
Copy link
Contributor

Problem

includes aren't sorted

Summary of Changes

  • sort includes with clang-format
  • groom away redundant include

working on #116, part of #683

@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #717 into master will decrease coverage by 2.42%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #717      +/-   ##
==========================================
- Coverage   60.18%   57.76%   -2.43%     
==========================================
  Files         130      130              
  Lines       12670    12650      -20     
==========================================
- Hits         7626     7307     -319     
- Misses       5044     5343     +299
Impacted Files Coverage Δ
src/inet/InetFaultInjection.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/ble/BleError.cpp 0.00% <0.00%> (-99.05%) ⬇️
src/inet/UDPEndPoint.cpp 0.00% <0.00%> (-63.81%) ⬇️
src/inet/IPAddress-StringFuncts.cpp 0.00% <0.00%> (-42.86%) ⬇️
src/inet/InetLayer.cpp 0.00% <0.00%> (-36.65%) ⬇️
src/lib/core/CHIPTLVTags.h 66.66% <0.00%> (-33.34%) ⬇️
src/setup_payload/SetupPayload.cpp 66.66% <0.00%> (-29.17%) ⬇️
src/lib/core/CHIPEncoding.h 73.91% <0.00%> (-18.68%) ⬇️
src/inet/IPAddress.cpp 0.00% <0.00%> (-18.25%) ⬇️
src/inet/InetError.cpp 0.00% <0.00%> (-2.16%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c4babc...59d5d7e. Read the comment docs.

@rwalker-apple
Copy link
Contributor Author

@hawk248 @jelderton @saurabhst ?

@woody-apple woody-apple merged commit 1182dc0 into project-chip:master May 15, 2020
@rwalker-apple rwalker-apple deleted the sort-includes-CHIP_Framework_iOS branch May 15, 2020 03:39
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request May 2, 2023
@rcasallas-silabs @jmartinez-silabs
Pull request project-chip#717: CPMS: TCP/IP connection support.
4540662 
Merge in WMN_TOOLS/matter from feature/cpms-tcp_ip to silabs

Squashed commit of the following:

commit cfcb20341b3b5ceaacdf9ff3e56eff1f5691f1b7
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Apr 28 08:28:32 2023 -0400

    CPMS: Code review.

commit 734d888f66edfaa42c95caf0eacf44990e830675
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 11:41:53 2023 -0400

    CPMS: JSON configuration improved.

commit 64884b9747e946709173cb71ef4b4bcff48b86bf
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 07:56:59 2023 -0400

    CPMS: TCP/IP connection support.
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request May 18, 2023
@rcasallas-silabs @jmartinez-silabs
Pull request project-chip#717: CPMS: TCP/IP connection support.
8014699 
Merge in WMN_TOOLS/matter from feature/cpms-tcp_ip to silabs

Squashed commit of the following:

commit cfcb20341b3b5ceaacdf9ff3e56eff1f5691f1b7
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Apr 28 08:28:32 2023 -0400

    CPMS: Code review.

commit 734d888f66edfaa42c95caf0eacf44990e830675
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 11:41:53 2023 -0400

    CPMS: JSON configuration improved.

commit 64884b9747e946709173cb71ef4b4bcff48b86bf
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 07:56:59 2023 -0400

    CPMS: TCP/IP connection support.
rerasool pushed a commit to SiliconLabs/matter that referenced this pull request Jun 23, 2023
@rcasallas-silabs @jmartinez-silabs
Pull request project-chip#717: CPMS: TCP/IP connection support.
4e1a1f2 
Merge in WMN_TOOLS/matter from feature/cpms-tcp_ip to silabs

Squashed commit of the following:

commit cfcb20341b3b5ceaacdf9ff3e56eff1f5691f1b7
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Apr 28 08:28:32 2023 -0400

    CPMS: Code review.

commit 734d888f66edfaa42c95caf0eacf44990e830675
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 11:41:53 2023 -0400

    CPMS: JSON configuration improved.

commit 64884b9747e946709173cb71ef4b4bcff48b86bf
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 07:56:59 2023 -0400

    CPMS: TCP/IP connection support.
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request Sep 1, 2023
@rcasallas-silabs @jmartinez-silabs
Pull request project-chip#717: CPMS: TCP/IP connection support.
5bfc038 
Merge in WMN_TOOLS/matter from feature/cpms-tcp_ip to silabs

Squashed commit of the following:

commit cfcb20341b3b5ceaacdf9ff3e56eff1f5691f1b7
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Apr 28 08:28:32 2023 -0400

    CPMS: Code review.

commit 734d888f66edfaa42c95caf0eacf44990e830675
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 11:41:53 2023 -0400

    CPMS: JSON configuration improved.

commit 64884b9747e946709173cb71ef4b4bcff48b86bf
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 07:56:59 2023 -0400

    CPMS: TCP/IP connection support.
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Oct 5, 2023
@rcasallas-silabs @jmartinez-silabs
Pull request project-chip#717: CPMS: TCP/IP connection support.
cd43cd6 
Merge in WMN_TOOLS/matter from feature/cpms-tcp_ip to silabs

Squashed commit of the following:

commit cfcb20341b3b5ceaacdf9ff3e56eff1f5691f1b7
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Apr 28 08:28:32 2023 -0400

    CPMS: Code review.

commit 734d888f66edfaa42c95caf0eacf44990e830675
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 11:41:53 2023 -0400

    CPMS: JSON configuration improved.

commit 64884b9747e946709173cb71ef4b4bcff48b86bf
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 07:56:59 2023 -0400

    CPMS: TCP/IP connection support.
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request Oct 25, 2023
@rcasallas-silabs @jmartinez-silabs
Pull request project-chip#717: CPMS: TCP/IP connection support.
6dab5bc 
Merge in WMN_TOOLS/matter from feature/cpms-tcp_ip to silabs

Squashed commit of the following:

commit cfcb20341b3b5ceaacdf9ff3e56eff1f5691f1b7
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Apr 28 08:28:32 2023 -0400

    CPMS: Code review.

commit 734d888f66edfaa42c95caf0eacf44990e830675
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 11:41:53 2023 -0400

    CPMS: JSON configuration improved.

commit 64884b9747e946709173cb71ef4b4bcff48b86bf
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 07:56:59 2023 -0400

    CPMS: TCP/IP connection support.
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Jan 11, 2024
@rcasallas-silabs @jmartinez-silabs
Pull request project-chip#717: CPMS: TCP/IP connection support.
42f064a 
Merge in WMN_TOOLS/matter from feature/cpms-tcp_ip to silabs

Squashed commit of the following:

commit cfcb20341b3b5ceaacdf9ff3e56eff1f5691f1b7
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Apr 28 08:28:32 2023 -0400

    CPMS: Code review.

commit 734d888f66edfaa42c95caf0eacf44990e830675
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 11:41:53 2023 -0400

    CPMS: JSON configuration improved.

commit 64884b9747e946709173cb71ef4b4bcff48b86bf
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 07:56:59 2023 -0400

    CPMS: TCP/IP connection support.
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request Jan 18, 2024
@rcasallas-silabs @jmartinez-silabs
Pull request project-chip#717: CPMS: TCP/IP connection support.
03e1122 
Merge in WMN_TOOLS/matter from feature/cpms-tcp_ip to silabs

Squashed commit of the following:

commit cfcb20341b3b5ceaacdf9ff3e56eff1f5691f1b7
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Apr 28 08:28:32 2023 -0400

    CPMS: Code review.

commit 734d888f66edfaa42c95caf0eacf44990e830675
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 11:41:53 2023 -0400

    CPMS: JSON configuration improved.

commit 64884b9747e946709173cb71ef4b4bcff48b86bf
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 07:56:59 2023 -0400

    CPMS: TCP/IP connection support.
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jan 29, 2024
@rcasallas-silabs @jmartinez-silabs
Pull request project-chip#717: CPMS: TCP/IP connection support.
3637eea 
Merge in WMN_TOOLS/matter from feature/cpms-tcp_ip to silabs

Squashed commit of the following:

commit cfcb20341b3b5ceaacdf9ff3e56eff1f5691f1b7
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Apr 28 08:28:32 2023 -0400

    CPMS: Code review.

commit 734d888f66edfaa42c95caf0eacf44990e830675
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 11:41:53 2023 -0400

    CPMS: JSON configuration improved.

commit 64884b9747e946709173cb71ef4b4bcff48b86bf
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 07:56:59 2023 -0400

    CPMS: TCP/IP connection support.
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jan 29, 2024
@rcasallas-silabs @jmartinez-silabs
Pull request project-chip#717: CPMS: TCP/IP connection support.
847117f 
Merge in WMN_TOOLS/matter from feature/cpms-tcp_ip to silabs

Squashed commit of the following:

commit cfcb20341b3b5ceaacdf9ff3e56eff1f5691f1b7
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Apr 28 08:28:32 2023 -0400

    CPMS: Code review.

commit 734d888f66edfaa42c95caf0eacf44990e830675
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 11:41:53 2023 -0400

    CPMS: JSON configuration improved.

commit 64884b9747e946709173cb71ef4b4bcff48b86bf
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 07:56:59 2023 -0400

    CPMS: TCP/IP connection support.
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request Feb 15, 2024
@rcasallas-silabs @jmartinez-silabs
Pull request project-chip#717: CPMS: TCP/IP connection support.
c1e0811 
Merge in WMN_TOOLS/matter from feature/cpms-tcp_ip to silabs

Squashed commit of the following:

commit cfcb20341b3b5ceaacdf9ff3e56eff1f5691f1b7
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Apr 28 08:28:32 2023 -0400

    CPMS: Code review.

commit 734d888f66edfaa42c95caf0eacf44990e830675
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 11:41:53 2023 -0400

    CPMS: JSON configuration improved.

commit 64884b9747e946709173cb71ef4b4bcff48b86bf
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 07:56:59 2023 -0400

    CPMS: TCP/IP connection support.
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this pull request May 8, 2024
@rcasallas-silabs @jmartinez-silabs
Pull request project-chip#717: CPMS: TCP/IP connection support.
06bf2c6 
Merge in WMN_TOOLS/matter from feature/cpms-tcp_ip to silabs

Squashed commit of the following:

commit cfcb20341b3b5ceaacdf9ff3e56eff1f5691f1b7
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Apr 28 08:28:32 2023 -0400

    CPMS: Code review.

commit 734d888f66edfaa42c95caf0eacf44990e830675
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 11:41:53 2023 -0400

    CPMS: JSON configuration improved.

commit 64884b9747e946709173cb71ef4b4bcff48b86bf
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 07:56:59 2023 -0400

    CPMS: TCP/IP connection support.
rcasallas-silabs added a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
@rcasallas-silabs @jmartinez-silabs
Pull request project-chip#717: CPMS: TCP/IP connection support.
450112e 
Merge in WMN_TOOLS/matter from feature/cpms-tcp_ip to silabs

Squashed commit of the following:

commit cfcb20341b3b5ceaacdf9ff3e56eff1f5691f1b7
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Apr 28 08:28:32 2023 -0400

    CPMS: Code review.

commit 734d888f66edfaa42c95caf0eacf44990e830675
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 11:41:53 2023 -0400

    CPMS: JSON configuration improved.

commit 64884b9747e946709173cb71ef4b4bcff48b86bf
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 07:56:59 2023 -0400

    CPMS: TCP/IP connection support.
rcasallas-silabs added a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
@rcasallas-silabs @jmartinez-silabs
Pull request project-chip#717: CPMS: TCP/IP connection support.
0545386 
Merge in WMN_TOOLS/matter from feature/cpms-tcp_ip to silabs

Squashed commit of the following:

commit cfcb20341b3b5ceaacdf9ff3e56eff1f5691f1b7
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Apr 28 08:28:32 2023 -0400

    CPMS: Code review.

commit 734d888f66edfaa42c95caf0eacf44990e830675
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 11:41:53 2023 -0400

    CPMS: JSON configuration improved.

commit 64884b9747e946709173cb71ef4b4bcff48b86bf
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 07:56:59 2023 -0400

    CPMS: TCP/IP connection support.
chirag-silabs pushed a commit to rosahay-silabs/connectedhomeip that referenced this pull request Jul 15, 2024
@rcasallas-silabs @jmartinez-silabs
Pull request project-chip#717: CPMS: TCP/IP connection support.
9c1c3b6 
Merge in WMN_TOOLS/matter from feature/cpms-tcp_ip to silabs

Squashed commit of the following:

commit cfcb20341b3b5ceaacdf9ff3e56eff1f5691f1b7
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Fri Apr 28 08:28:32 2023 -0400

    CPMS: Code review.

commit 734d888f66edfaa42c95caf0eacf44990e830675
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 11:41:53 2023 -0400

    CPMS: JSON configuration improved.

commit 64884b9747e946709173cb71ef4b4bcff48b86bf
Author: Ricardo Casallas <ricardo.casallas@silabs.com>
Date:   Thu Apr 27 07:56:59 2023 -0400

    CPMS: TCP/IP connection support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerickson gerickson gerickson approved these changes

@saurabhst saurabhst saurabhst approved these changes

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@BroderickCarlin BroderickCarlin Awaiting requested review from BroderickCarlin

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rwalker-apple @gerickson @saurabhst @woody-apple