-
-
Notifications
You must be signed in to change notification settings - Fork 382
NEW [WIP] Add localization support with jekyll-simple-i18n #1509
base: master
Are you sure you want to change the base?
Conversation
Adds in support for https://github.com/signalapp/jekyll-simple-i18n. The plugin did not work with the github-pages gem, so github-pages was switched with jekyll (which is what the current i18n branch does anyway).
* Translate more of index.html, with translations sourced from deepl.com * Relax the plugin to allow capitalization, periods, exclamation marks, and question marks in the Weblate ID for YAML src. This helps differentiate between similar but different strings.
Deploy preview for privacytools-io ready! Built with commit e5cfd44 |
_includes/sections/resources.html
Outdated
{% capture os_title %}{% t Operating Systems%}{% endcapture %} | ||
{% capture os_page %}/{% if page.language %}{{ page.language }}/{% endif %}operating-systems/{% endcapture %} | ||
{% capture os_description %}{% t Find out how your operating system is compromising your privacy, and what simple alternatives exist.%}{% endcapture %} | ||
|
||
{% include card.html color="info" | ||
title="Operating Systems" | ||
title=os_title | ||
icon="fas fa-desktop" | ||
iconcolor="dark" | ||
page="/operating-systems/" | ||
description="Find out how your operating system is compromising your privacy, and what simple alternatives exist." | ||
page=os_page | ||
description=os_description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there is a way to incorporate this into the card.html
code instead of using captures on every page. Will have to investigate that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description should link to https://deploy-preview-1509--privacytools-io.netlify.com instead of https://deploy-preview-1503--privacytools-io.netlify.com |
List of some issues:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I'm not sure what's going on with Weblate, it might be a known issue (WeblateOrg/weblate#3231) or I might just need to look at it tomorrow with fresh eyes. In either case, it allows for anonymous suggestions and it works otherwise, so I'll get registrations figured out at a later time. |
Updated by "Cleanup translation files" hook in Weblate. Translation: PrivacyTools/Website Translate-URL: https://weblate.nablahost.com/projects/privacytoolsio/website/
Seems like Weblate thinks that there's a newline at the end of every string |
I've noticed that for regenerating the source file, it seems the best thing to do is to make sure Jekyll isn't serving the site when the file is regenerated. e.g.,
|
I have noticed that as well. Maybe it would be better if we did add the file to .gitignore and have a bot of some kind build the source file and push it to the repo when changes are made. But for now at least I think we can handle it easily manually.
I saw that but didn't get a chance to look further. The issue, I believe, is this space between each key:
In YAML, the What I don't know is whether or not the |
The plugin itself also does |
I've "solved" the email problem temporarily by enabling Sign in with GitHub and GitLab. So feel free to register an account, just don't sign up with email :) |
@jonaharagon I looked it up (https://yaml.org/YAML_for_ruby.html#three_trailing_newlines_in_literals). Apparently |
* Key classic page * Key missed strings * Update source file
cd416cf
to
b22948b
Compare
Currently translated at 0.8% (15 of 1876 strings) Translation: PrivacyTools/Website Translate-URL: https://weblate.nablahost.com/projects/privacytoolsio/website/ca/
Currently translated at 0.8% (15 of 1876 strings) Translation: PrivacyTools/Website Translate-URL: https://weblate.nablahost.com/projects/privacytoolsio/website/ca/
@jonaharagon What's the status of this PR? There was some people looking to localize the site recently (https://www.reddit.com/r/privacytoolsIO/comments/enui17/arabic_version_of_privacytoolsio/). For things to do before this can be considered ready,
|
Hi. Would it be possible to reopen discussions around translations? This issue struggles since a long time but is, IMHO, one of the most important one. |
@Booteille My thoughts on the state of translations progress is given at #1106 (comment) |
Supersedes #1458. This brings changes from #1503 into the main repo for development.
@djoate:
Preview of index.html translation: https://deploy-preview-1509--privacytools-io.netlify.com/es/
English site: https://deploy-preview-1509--privacytools-io.netlify.com
Sample of partially translated pages:
Every other page has not been translated (pages without
translate: true
in front matter are not generated)This is not meant to be a full-fledged PR but rather a proof of concept for a better solution for localizing the site. If this is an acceptable solution, please make this into a branch in this repository so that we can start localizing using this plugin.
With the jekyll-simple-i18n plugin (MIT licensed), this makes translating the site easier to manage. You should visit the plugin's GitHub repository and read up on it, but here are the features of this plugin from their README:
It's based on Transifex, but it can be used with a different service such as Weblate. I've made some modifications to the plugin (e.g. renaming transifex to weblate and handling null source text).
This PR includes an example of index.html and a part of card.html (The "Learn More" button text) being translated. The plugin did not seem to work with the github-pages gem, so github-pages was switched with jekyll gem (which is what the current i18n branch does anyway). You can go to https://deploy-preview-1509--privacytools-io.netlify.com/es/ (or build locally) to see the following:
https://deploy-preview-1509--privacytools-io.netlify.com gives the original English site.
Here is a snippet of the source code for index.html:
A snippet of resources.html:
Instead of using keys and two different files, you just wrap the original text around with
{% t ... %}
tags, and the plugin will automatically key that string (with its own ID) intoweblate-source-file.yml
. If you are trying to translate things inside of a card, you have to do the same thing as before with capturing text.The source YAML is generated on build into the root folder of the repo. This source file can then be copied into
_data/languages/
and then renamed into one of the languages in the language map to set up a translation. This seems much easier to maintain compared to cross referencing between two different files.The plugin will also not create multiple keys for duplicates of the exact same string. For example,
{% t Worth Mentioning %}
will have one key associated with it, and there will only be one key to translate. All other pages that use{% t Worth Mentioning %}
will share the same key (however, I've modified it so that, for instance,{% t Worth mentioning %}
and{% t Worth Mentioning! %}
would have distinct keys)We would have to replace local links with something like this in order to get the right pages (and I believe external links can be wrapped in
translate
tags without a problem):A porition of the source file,
weblate-source-file.yml
, looks like this:It's a different format when compared to what is currently in the i18n branch now, i.e. it has the format
rather than
If this format doesn't work with Weblate, we can change the plugin so that it generates the latter format.
A sample translation into Spanish (using deepl.com) can be found in
_data/languages/es.yml
:Known issues
https://privacytools.io/es/donate
will have to stay as/es/donate
for now. Update: See comment below since this is actually not an issue.jekyll-sitemap
plugin also had to be explicitly added in order for the site to compile.To reiterate, this is a proof of concept for a better i18n solution. Feel free to add this as a branch if this seems like an acceptable solution.