This repository was archived by the owner on Jun 24, 2022. It is now read-only.
i18n: Proposal to use jekyll-simple-i18n plugin instead of jekyll-multiple-languages#1503
Closed
djoate wants to merge 9 commits intoprivacytools:masterfrom
djoate:i18n-simple
Closed
i18n: Proposal to use jekyll-simple-i18n plugin instead of jekyll-multiple-languages#1503djoate wants to merge 9 commits intoprivacytools:masterfrom djoate:i18n-simple
djoate wants to merge 9 commits intoprivacytools:masterfrom
djoate:i18n-simple
Conversation
Adds in support for https://github.com/signalapp/jekyll-simple-i18n. The plugin did not work with the github-pages gem, so github-pages was switched with jekyll (which is what the current i18n branch does anyway).
* Translate more of index.html, with translations sourced from deepl.com * Relax the plugin to allow capitalization, periods, exclamation marks, and question marks in the Weblate ID for YAML src. This helps differentiate between similar but different strings.
|
Deploy preview for privacytools-io ready! Built with commit 1472c27 |
Contributor
|
Instead of using keys and two different files, you just wrap the
original text around with `{% translate ... %}` tags, and the plugin
will automatically key that string (with its own ID) into
`weblate-source-file.yml`. If you are trying to translate things
inside of a card, you have to do the same thing as before with
capturing text.
That's actually a thing I wanted to build :P.
- I don't know of a way to make the plugin translate the strings of
permalinks.
That's good, it's more predictable and easier to implement (like for
example if user would switch language while being on some subpage).
|
Contributor
|
Okay. This looks good to me. A saner solution, I think. We can't use Transifex. If this works with Weblate, which it should, we're fine. We don't want to add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to issue https://github.com/privacytoolsIO/privacytools.io/issues/1106.
Tagging @jonaharagon since i18n was your project.
Preview of index.html translation: https://deploy-preview-1503--privacytools-io.netlify.com/es/
Original site: https://deploy-preview-1503--privacytools-io.netlify.com
Sample of partially translated pages:
Every other page has not been translated (pages without
translate: truein front matter are not generated)This is not meant to be a full-fledged PR but rather a proof of concept for a better solution for localizing the site. If this is an acceptable solution, please make this into a branch in this repository so that we can start localizing using this plugin.
With the jekyll-simple-i18n plugin (MIT licensed), this makes translating the site easier to manage. You should visit the plugin's GitHub repository and read up on it, but here are the features of this plugin from their README:
It's based on Transifex, but it can be used with a different service such as Weblate. I've made some modifications to the plugin (e.g. renaming transifex to weblate and handling null source text).
This PR includes an example of index.html and a part of card.html (The "Learn More" button text) being translated. The plugin did not seem to work with the github-pages gem, so github-pages was switched with jekyll gem (which is what the current i18n branch does anyway). You can go to https://deploy-preview-1503--privacytools-io.netlify.com/es/ (or build locally) to see the following:
https://deploy-preview-1503--privacytools-io.netlify.com gives the original English site.
Here is a snippet of the source code for index.html:
A snippet of resources.html:
Instead of using keys and two different files, you just wrap the original text around with
{% t ... %}tags, and the plugin will automatically key that string (with its own ID) intoweblate-source-file.yml. If you are trying to translate things inside of a card, you have to do the same thing as before with capturing text.The source YAML is generated on build into the root folder of the repo. This source file can then be copied into
_data/languages/and then renamed into one of the languages in the language map to set up a translation. This seems much easier to maintain compared to cross referencing between two different files.The plugin will also not create multiple keys for duplicates of the exact same string. For example,
{% t Worth Mentioning %}will have one key associated with it, and there will only be one key to translate. All other pages that use{% t Worth Mentioning %}will share the same key (however, I've modified it so that, for instance,{% t Worth mentioning %}and{% t Worth Mentioning! %}would have distinct keys)We would have to replace local links with something like this in order to get the right pages (and I believe external links can be wrapped in
translatetags without a problem):A porition of the source file,
weblate-source-file.yml, looks like this:It's a different format when compared to what is currently in the i18n branch now, i.e. it has the format
rather than
If this format doesn't work with Weblate, we can change the plugin so that it generates the latter format.
A sample translation into Spanish (using deepl.com) can be found in
_data/languages/es.yml:Known issues
https://privacytools.io/es/donatewill have to stay as/es/donatefor now. Update: See comment below since this is actually not an issue.jekyll-sitemapplugin also had to be explicitly added in order for the site to compile.To reiterate, this is a proof of concept for a better i18n solution. Feel free to add this as a branch if this seems like an acceptable solution.