refactor(ButtonBase): To use CSS modules behind the feature flag #4827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b0bd7ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jonrohan
reviewed
Aug 8, 2024
Co-authored-by: Jon Rohan <yes@jonrohan.codes>
jonrohan
reviewed
Aug 8, 2024
jonrohan
reviewed
Aug 8, 2024
jonrohan
reviewed
Aug 8, 2024
Co-authored-by: Jon Rohan <yes@jonrohan.codes>
* refactor: remove SSRProvider and useSSRSafeId * chore: remove unused eslint disables * chore: remove unused prop --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
* Update snapshots * Add changeset
* Refactor Link to use CSS modules * Remove needless disable * Add newline * Create quick-adults-buy.md * Run tests inside fhte feature flag also * Fix naming * Rails interpolation got me * test(e2e): update e2e tests for link (#4825) Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * Remove example-nextjs --------- Co-authored-by: Josh Black <joshblack@github.com> Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
* refactor(Heading): update component to CSS Modules * test(e2e): add feature flags for Heading test * chore: fix stylelint errors * test(e2e): update snapshots for Heading * refactor(Heading): incorporate variant features into CSS Modules * chore: add changeset * test(e2e): remove theme testing * Fix props here * Remove examples/nextjs * Clean up css --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com> Co-authored-by: Jon Rohan <yes@jonrohan.codes>
…nto button-css-module
jonrohan
changed the title
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/github/primer/issues/3815
Changelog
Changed
Rollout strategy
Testing & Reviewing
Snapshots should match with flag on/off
Merge checklist