Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Link component to use CSS modules #4828

Merged
merged 12 commits into from
Aug 14, 2024
Merged

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Aug 8, 2024

Part of https://github.com/github/primer/issues/3719

Changed

  • Update Link component to use CSS Modules
  • Add feature flag to Link component to toggle between styled-components and CSS Modules
  • Use feature flag for VRT in Link

Removed

Rollout strategy

  • Minor release

Testing & Reviewing

Copy link

changeset-bot bot commented Aug 8, 2024

🦋 Changeset detected

Latest commit: 6f10e4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Aug 8, 2024
Copy link
Contributor

github-actions bot commented Aug 8, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.13 KB (-0.08% 🔽)
packages/react/dist/browser.umd.js 96.48 KB (+0.03% 🔺)

joshblack and others added 2 commits August 12, 2024 20:13
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jonrohan jonrohan added this pull request to the merge queue Aug 14, 2024
Merged via the queue into main with commit 1a674f7 Aug 14, 2024
31 checks passed
@jonrohan jonrohan deleted the css_modules_convert_link branch August 14, 2024 22:18
@primer primer bot mentioned this pull request Aug 14, 2024
jonrohan added a commit that referenced this pull request Aug 15, 2024
* Refactor Link to use CSS modules

* Remove needless disable

* Add newline

* Create quick-adults-buy.md

* Run tests inside fhte feature flag also

* Fix naming

* Rails interpolation got me

* test(e2e): update e2e tests for link (#4825)

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

* Remove example-nextjs

---------

Co-authored-by: Josh Black <joshblack@github.com>
Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants