Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): update e2e tests for link #4825

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

joshblack
Copy link
Member

Update e2e tests for Link to include more cases for VRT and remove disabled contrast checks

Changelog

New

Changed

  • Update Link e2e tests to include snapshots for additional stories
  • Update Link a11y tests to no longer disable contrast checks

Removed

Rollout strategy

  • None; if selected, include a brief description as to why

This is a change to our e2e tests for link and do not effect the public API of the component

@joshblack joshblack requested review from a team as code owners August 7, 2024 19:56
Copy link

changeset-bot bot commented Aug 7, 2024

⚠️ No Changeset found

Latest commit: 5b515e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Aug 7, 2024
@joshblack joshblack added the skip changeset This change does not need a changelog label Aug 7, 2024
Copy link
Contributor

github-actions bot commented Aug 7, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.05 KB (0%)
packages/react/dist/browser.umd.js 96.39 KB (0%)

@joshblack
Copy link
Member Author

bump @langermank when you get a sec!

@joshblack joshblack added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit 41b75de Aug 12, 2024
36 of 37 checks passed
@joshblack joshblack deleted the test/update-test-for-link branch August 12, 2024 19:21
jonrohan pushed a commit that referenced this pull request Aug 12, 2024
Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Aug 14, 2024
* Refactor Link to use CSS modules

* Remove needless disable

* Add newline

* Create quick-adults-buy.md

* Run tests inside fhte feature flag also

* Fix naming

* Rails interpolation got me

* test(e2e): update e2e tests for link (#4825)

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

* Remove example-nextjs

---------

Co-authored-by: Josh Black <joshblack@github.com>
Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
jonrohan added a commit that referenced this pull request Aug 15, 2024
* Refactor Link to use CSS modules

* Remove needless disable

* Add newline

* Create quick-adults-buy.md

* Run tests inside fhte feature flag also

* Fix naming

* Rails interpolation got me

* test(e2e): update e2e tests for link (#4825)

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

* Remove example-nextjs

---------

Co-authored-by: Josh Black <joshblack@github.com>
Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants