Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ButtonBase): To use CSS modules behind the feature flag #4827

Closed
wants to merge 56 commits into from
Closed

refactor(ButtonBase): To use CSS modules behind the feature flag #4827

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
62e9e2f
copy from other branch
langermank Aug 7, 2024
6d11e09
setup feature flag
langermank Aug 8, 2024
0fa1ff9
Update packages/react/src/Button/ButtonBase.tsx
langermank Aug 8, 2024
59c102f
Update packages/react/src/Button/ButtonBase.tsx
langermank Aug 8, 2024
e816bb3
Merge branch 'main' into button-css-module
langermank Aug 14, 2024
c21f792
use Text component
langermank Aug 14, 2024
68ad08b
refactor: remove SSRProvider and useSSRSafeId (#4783)
joshblack Aug 14, 2024
5a51d41
ProgressBar: Remove `aria-busy` from `ProgressBar` (#4841)
TylerJDev Aug 14, 2024
1e249d5
Refactor Link component to use CSS modules (#4828)
jonrohan Aug 14, 2024
fa85ca1
refactor(Heading): update component to CSS Modules (#4819)
joshblack Aug 14, 2024
b6767da
Merge branch 'main' into button-css-module
jonrohan Aug 15, 2024
5b87418
Create beige-guests-serve.md
jonrohan Aug 15, 2024
a0eca09
Merge branch 'button-css-module' of https://github.com/primer/react i…
langermank Aug 15, 2024
ef0ed02
Fix sxProp check
jonrohan Aug 15, 2024
4eb49e5
render align
jonrohan Aug 15, 2024
2cc29ad
Rendering leadingVisual in cssmodules
jonrohan Aug 15, 2024
9f883a2
Don't pass module classes to old component
jonrohan Aug 15, 2024
6116ca4
Update Button test for feature flag
jonrohan Aug 15, 2024
5a85807
working on selectors
langermank Aug 16, 2024
0d37403
cleanup
langermank Aug 16, 2024
7a78f06
lint
langermank Aug 16, 2024
4876cf4
added ts ignore 🤷
siddharthkp Aug 20, 2024
8ff99bf
add classname to both components
siddharthkp Aug 20, 2024
553b833
update IconButton snapshot
siddharthkp Aug 20, 2024
a9624f7
test(vrt): update snapshots
langermank Aug 20, 2024
6be51fd
Merge branch 'main' into button-css-module
jonrohan Aug 23, 2024
1206265
Change feature flag to primer_react_css_modules_team
jonrohan Aug 23, 2024
927c020
fixed based on integration test
langermank Aug 27, 2024
caaf79e
reset
langermank Aug 27, 2024
f77b614
Merge branch 'main' into button-css-module
langermank Aug 28, 2024
dc90e5f
Merge branch 'main' into button-css-module
langermank Aug 28, 2024
abea8eb
test(vrt): update snapshots
langermank Aug 28, 2024
4adf9c1
test(vrt): update snapshots
langermank Aug 28, 2024
1e2b6c9
Merge branch 'main' into button-css-module
langermank Aug 28, 2024
2f6d979
Merge branch 'main' into button-css-module
langermank Sep 5, 2024
e9e59d2
lint
langermank Sep 5, 2024
33e9f27
reset
langermank Sep 5, 2024
248be04
test(vrt): update snapshots
langermank Sep 5, 2024
701ac5d
Merge branch 'main' into button-css-module
langermank Sep 5, 2024
6723e4a
reset
langermank Sep 5, 2024
5b2556d
test(e2e): update snapshots
joshblack Sep 5, 2024
b75ad97
loading styles + line height
langermank Sep 5, 2024
7e4657f
test(vrt): update snapshots
langermank Sep 5, 2024
17f6497
reset line-height for now
langermank Sep 6, 2024
2e7b571
reset
langermank Sep 6, 2024
1fcf304
Merge branch 'main' into button-css-module
langermank Sep 6, 2024
811b650
test(vrt): update snapshots
langermank Sep 6, 2024
e77f7af
fix loading
langermank Sep 6, 2024
6a0042a
Merge branch 'main' into button-css-module
langermank Sep 6, 2024
108ecfa
Merge branch 'button-css-module' of https://github.com/primer/react i…
langermank Sep 6, 2024
7e36149
lint
langermank Sep 6, 2024
3d9f02f
bug fixes
langermank Sep 9, 2024
e56a030
Merge branch 'main' into button-css-module
langermank Sep 9, 2024
caad4d4
fix story
langermank Sep 9, 2024
8775327
Merge branch 'button-css-module' of https://github.com/primer/react i…
langermank Sep 9, 2024
b0bd7ad
try rebuild sb
langermank Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading