-
Notifications
You must be signed in to change notification settings - Fork 645
Closed
Labels
Description
Currently there are console.{error,warn,log} statements being emitted when running npm test. This can be confusing to contributors who may not understand if the issues are pre-existing or caused by changes that they made when making a contribution.
This issue has two goals:
- Add a system by which we can fail tests that call
console.{error, warn, log}(Note:console.log()should only fail in CI) - Update tests which currently fail when adding this check
-
src/drafts/MarkdownEditor/MarkdownEditor.test.tsx -
src/__tests__/useSafeTimeout.test.tsx -
src/__tests__/TabNav.test.tsx -
src/drafts/MarkdownViewer/MarkdownViewer.test.tsx -
src/__tests__/Textarea.test.tsx -
src/drafts/hooks/useIgnoreKeyboardActionsWhileComposing.test.tsx -
src/__tests__/RadioGroup.test.tsx -
src/__tests__/Select.test.tsx -
src/__tests__/Radio.test.tsx -
src/__tests__/CheckboxGroup.test.tsx -
src/__tests__/CheckboxOrRadioGroup.test.tsx -
src/NavList/NavList.test.tsx -
src/__tests__/deprecated/ChoiceInputField.test.tsx -
src/__tests__/Autocomplete.test.tsx -
src/SegmentedControl/SegmentedControl.test.tsx -
src/__tests__/FormControl.test.tsx -
src/__tests__/ThemeProvider.test.tsx - Overlay
-