-
Notifications
You must be signed in to change notification settings - Fork 645
test(TabNav): remove nested <a> from test #2527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
size-limit report 📦
|
broccolinisoup
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this test is written recently and seems like a valid case but should it be a link ? In the PR description, it mentions about a case where there is a nested button inside the tab so maybe instead of removing this test case, we can use a button element and still make sure to cover nested buttons test?
|
@broccolinisoup I think what they end up doing in Memex is changing the container |
|
bump @siddharthkp @broccolinisoup let me know if you have any questions! |
Ah I see. Thanks for clarification! I feel like we are good without testing this case as it is very specific to their implementation and not necessarily a part of the TabNav functionality |
Remove the nested
<a>fromTabNav.Link. This helps to avoid the followingvalidateDOMNestingerror that comes from React:This also updates the test to reference only the tab and no longer includes the link.