Skip to content

Conversation

@joshblack
Copy link
Member

Update the ChoiceInputField tests to use mockImplementation on the console.warn() spy. This prevents the console.warn() message from being emitted to the console during tests.

This change also updates each check to explicitly check for the message to make sure that no other console.warn() message is being emitted other than what is being tested for.

@joshblack joshblack requested review from a team and broccolinisoup November 1, 2022 21:17
@changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2022

⚠️ No Changeset found

Latest commit: ffcbf5c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added the skip changeset This change does not need a changelog label Nov 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 78.82 KB (0%)
dist/browser.umd.js 79.47 KB (0%)

@joshblack joshblack temporarily deployed to github-pages November 1, 2022 21:24 Inactive
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it 😍 I'll add this to my tests as well!

@joshblack joshblack enabled auto-merge (squash) November 2, 2022 15:26
@joshblack joshblack merged commit 819e027 into main Nov 2, 2022
@joshblack joshblack deleted the test/update-choice-input-field branch November 2, 2022 15:31
@joshblack joshblack temporarily deployed to github-pages November 2, 2022 15:32 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants