Skip to content

test(ChoiceInputField): add mockImplementation to warning tests #2516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2022
Merged

test(ChoiceInputField): add mockImplementation to warning tests #2516

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d31106d
test(ChoiceInputField): add mockImplementation to warning tests
joshblack Nov 1, 2022
ffcbf5c
Merge branch 'main' into test/update-choice-input-field
joshblack Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions src/__tests__/deprecated/ChoiceInputField.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ describe('ChoiceInputField', () => {

describe('warnings', () => {
it('should warn users if they do not pass an input', async () => {
const consoleSpy = jest.spyOn(global.console, 'warn')
const consoleSpy = jest.spyOn(global.console, 'warn').mockImplementation(() => {})
render(
<SSRProvider>
<ChoiceInputField>
Expand All @@ -151,11 +151,13 @@ describe('ChoiceInputField', () => {
</SSRProvider>
)

expect(consoleSpy).toHaveBeenCalled()
expect(consoleSpy).toHaveBeenCalledWith(
'To correctly render this field with the correct ARIA attributes passed to the input, please pass the Checkbox or Radio component from @primer/react as a direct child of the ChoiceInputField component'
)
})

it('should warn users if they pass an id directly to the input', async () => {
const consoleSpy = jest.spyOn(global.console, 'warn')
const consoleSpy = jest.spyOn(global.console, 'warn').mockImplementation(() => {})
render(
<SSRProvider>
<ChoiceInputField>
Expand All @@ -166,11 +168,13 @@ describe('ChoiceInputField', () => {
</SSRProvider>
)

expect(consoleSpy).toHaveBeenCalled()
expect(consoleSpy).toHaveBeenCalledWith(
`instead of passing the 'id' prop directly to the checkbox input, it should be passed to the parent component, <ChoiceInputField>`
)
})

it('should warn users if they pass a `disabled` prop directly to the input', async () => {
const consoleSpy = jest.spyOn(global.console, 'warn')
const consoleSpy = jest.spyOn(global.console, 'warn').mockImplementation(() => {})
render(
<SSRProvider>
<ChoiceInputField>
Expand All @@ -181,11 +185,13 @@ describe('ChoiceInputField', () => {
</SSRProvider>
)

expect(consoleSpy).toHaveBeenCalled()
expect(consoleSpy).toHaveBeenCalledWith(
`instead of passing the 'disabled' prop directly to the checkbox input, it should be passed to the parent component, <ChoiceInputField>`
)
})

it('should warn users if they pass a `required` prop directly to the input', async () => {
const consoleSpy = jest.spyOn(global.console, 'warn')
const consoleSpy = jest.spyOn(global.console, 'warn').mockImplementation(() => {})
render(
<SSRProvider>
<ChoiceInputField>
Expand All @@ -196,7 +202,9 @@ describe('ChoiceInputField', () => {
</SSRProvider>
)

expect(consoleSpy).toHaveBeenCalled()
expect(consoleSpy).toHaveBeenCalledWith(
`instead of passing the 'required' prop directly to the checkbox input, it should be passed to the parent component, <ChoiceInputField>`
)
})
})

Expand Down