test(Overlay): add spy for console.log() from stories #2515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
Overlaytests to no longer emitconsole.log()from the stories. This approach usesjest.spyOnplusmockImplementationto preventconsole.log()from preventing into the tests.Since
console.log()may be used for other parts of the test, it also has a guard in caseconsole.log()is called with something other than what was expected from the storyChangelog
New
Changed
console.log()to avoid logging in testsRemoved
expect.extend(toHaveNoViolations)as it should be automatically loaded in the environment