Skip to content

Conversation

@joshblack
Copy link
Member

Update the Overlay tests to no longer emit console.log() from the stories. This approach uses jest.spyOn plus mockImplementation to prevent console.log() from preventing into the tests.

Since console.log() may be used for other parts of the test, it also has a guard in case console.log() is called with something other than what was expected from the story

Changelog

New

Changed

  • Add a spy for console.log() to avoid logging in tests

Removed

  • Removed expect.extend(toHaveNoViolations) as it should be automatically loaded in the environment

@joshblack joshblack added the skip changeset This change does not need a changelog label Nov 1, 2022
@joshblack joshblack requested review from a team and josepmartins November 1, 2022 21:11
@changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2022

⚠️ No Changeset found

Latest commit: e8508b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 78.82 KB (0%)
dist/browser.umd.js 79.47 KB (0%)

@joshblack joshblack temporarily deployed to github-pages November 1, 2022 21:18 Inactive
Copy link
Contributor

@josepmartins josepmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshblack joshblack enabled auto-merge (squash) November 2, 2022 15:06
@joshblack joshblack temporarily deployed to github-pages November 2, 2022 15:12 Inactive
@joshblack joshblack merged commit 40e7aad into main Nov 2, 2022
@joshblack joshblack deleted the test/update-overlay-test branch November 2, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants