Open
Conversation
ppadma
reviewed
May 30, 2018
|
|
||
| <root> | ||
| <level value="error"/> | ||
| <level value="error"/>o |
| </logger> | ||
|
|
||
| <!--logger name="org.apache.drill" additivity="false"> | ||
| <level value="debug" /> |
Owner
There was a problem hiding this comment.
you might want to undo this change. this will enable all debug log.
| } | ||
|
|
||
| // public <T, V, E extends Exception> T accept(AbstractExecExprVisitor<T, V, E> visitor, V value) throws E { | ||
| // return visitor.visitValueVectorWriteExpression(this, value); |
| // Custom calculator are place holder markers on functions until support | ||
| // for CUSTOM calculators is implemented | ||
| CUSTOM(OutputWidthCalculators.DefaultOutputWidthCalculator.INSTANCE), | ||
| CUSTOM2(OutputWidthCalculators.CloneOutputWidthCalculator.INSTANCE); |
Owner
There was a problem hiding this comment.
why we need CUSTOM and CUSTOM2 ? Can you add comments ?
|
|
||
| OutputWidthCalculatorType outputWidthCalculatorType() default OutputWidthCalculatorType.DEFAULT; | ||
|
|
||
| int VARIABLE_OUTPUT_SIZE_ESTIMATE_DEFAULT = -1; |
Owner
There was a problem hiding this comment.
make it static final. Also, -1 seems dangerous. can we initialize it to some value that will not cause problems if used ?
| } | ||
|
|
||
| public boolean isComplex(MajorType majorType) { | ||
| MinorType minorType = majorType.getMinorType(); |
Owner
There was a problem hiding this comment.
recordBatchSizer has similar functions. can we make these common ?
|
|
||
| boolean isFixedWidth(TypedFieldId fieldId) { | ||
| ValueVector vv = getOutgoingValueVector(fieldId); | ||
| return (vv instanceof FixedWidthVector); |
|
|
||
| int stdDataSize = 0; | ||
|
|
||
| if (isOptional) { stdDataSize += BIT_VECTOR_WIDTH; } |
Owner
There was a problem hiding this comment.
why can't you get getStdSize from recordBatchSizer
|
|
||
| static int getWidthOfFixedWidthType(ValueVector vv) { | ||
| assert isFixedWidth(vv); | ||
| return vv.getPayloadByteCount(1); |
Owner
There was a problem hiding this comment.
instead of getPayloadByteCount, isn't there a function like getValueWidth or something like that ?
| //Variable width transfers | ||
| if(outputColumnType == OutputColumnType.TRANSFER) { | ||
| String columnName = path; | ||
| VarLenReadExpr readExpr = new VarLenReadExpr(columnName); |
Owner
There was a problem hiding this comment.
create a function addVariableWidthField so it is easy to read the code.
…ib module This closes apache#1201
…tadata Format Plugin - See https://issues.apache.org/jira/browse/DRILL-4364 This closes apache#367
This closes apache#1227
…est case for DRILLBIT_CONTEXT variable This closes apache#1289
…oken
When viewing a profile for a query against a JDBC source, the visualized plan is not rendered. This is because the generated SQL pushed down to the JDBC source has a line break injected just before the FROM clause.
The workaround is to strip away any injected newlines ('\\n') at least for the SQL defined in the text plan, so that the backend Javascript can render it correctly.
In addition, any single line comments are also removed, but any block comments (i.e. /* .. */ ) are retained as they might carry hints.
This closes apache#1295
…of Lateral Join. This closes apache#1299
…d on the HBase row key - Added a condition that checks if the filter to the scan specification doesn't have NOT_EQUAL operator - Added testFilterPushDownRowKeyNotEqual() to TestHBaseFilterPushDown This closes apache#309
…lient. This closes #5584
…when used on the HBase row key" This reverts commit 0d5eda8.
added 29 commits
June 3, 2018 11:46
…estProjectVariableWidthFunctions
karthik-man
force-pushed
the
KM-DRILL-6340-VAR-2
branch
from
db9ce25 to
73e1264
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.