DRILL-6445: Fix existing test cases in TestScripts.java and add new t…#1289
Closed
sohami wants to merge 1 commit intoapache:masterfrom
Closed
DRILL-6445: Fix existing test cases in TestScripts.java and add new t…#1289sohami wants to merge 1 commit intoapache:masterfrom
sohami wants to merge 1 commit intoapache:masterfrom
Conversation
…est case for DRILLBIT_CONTEXT variable
Contributor
Author
|
@ilooner / @paul-rogers - Can you please help to review this ? |
ilooner
approved these changes
May 24, 2018
Contributor
ilooner
left a comment
ilooner
left a comment
There was a problem hiding this comment.
I don't have much context on the expected behavior here, so I can only make general comments. LGTM +1 . You code is very clean :) .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…est case for DRILLBIT_CONTEXT variable