DRILL-4364: Image Metadata Format Plugin#367
Conversation
|
@vkorukanti, @jaltekruse, @adityakishore - since each of you have written format plugins in the past, can one of you help code review this change? |
|
@nagix Are you still working on this? What is the status? |
|
@cgivre Yes, I'm still working on this. Since the dependent library (metadata-extractor) has been updated, I need to add some changes according to it. I will push another commit shortly. |
|
@cgivre I have made the code up to date. Can you review this? |
|
@nagix I'd be happy to review it, but I'm not a Drill committer. |
|
@nagix I just became a committer, and I'd really love to see this incorporated into the latest version of Drill. Are you willing to keep working on this to finish it? If not, I may have some time to complete it. |
|
Congratulations, @cgivre! I will check the latest version of the dependent library, and rebase this branch. |
|
@nagix Did you get a chance to rebase this commit? |
|
I have updated the dependent library and rebased the code. Now, Image Metadata Format Plugin supports:
See also the original JIRA (DRILL-4364) and the document. |
085e593 to
bb6eead
Compare
36fc7e4 to
53f8e27
Compare
|
@nagix Can you please fix the conflict with |
- Initial commit of Image Metadata Format Plugin - See https://issues.apache.org/jira/browse/DRILL-4364
|
@cgivre I have fixed the conflict and squashed the commit. |
|
+1 LGTM. Built successfully and ran queries in embedded mode. Thank you for your contribution to Drill! |
Initial commit of the Image Metadata Format Plugin