DRILL-6450: Visualized plans for profiles querying JDBC sources is broken#1295
Closed
kkhatua wants to merge 1 commit intoapache:masterfrom
Closed
DRILL-6450: Visualized plans for profiles querying JDBC sources is broken#1295kkhatua wants to merge 1 commit intoapache:masterfrom
kkhatua wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
Before: After:
|
Contributor
Author
|
@amansinha100 can you do a review for this small PR? |
…oken
When viewing a profile for a query against a JDBC source, the visualized plan is not rendered. This is because the generated SQL pushed down to the JDBC source has a line break injected just before the FROM clause.
The workaround is to strip away any injected newlines ('\\n') at least for the SQL defined in the text plan, so that the backend Javascript can render it correctly.
In addition, any single line comments are also removed, but any block comments (i.e. /* .. */ ) are retained as they might carry hints.
amansinha100
approved these changes
May 31, 2018
amansinha100
left a comment
amansinha100
left a comment
There was a problem hiding this comment.
We don't have much test coverage for the jdbc plugin but since this PR at least fixes the basic rendering of the visual plan, I am +1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When viewing a profile for a query against a JDBC source, the visualized plan is not rendered. This is because the generated SQL pushed down to the JDBC source has a line break injected just before the FROM clause.
The workaround is to strip away any injected newlines ('\n') at least for the SQL defined in the text plan, so that the backend Javascript can render it correctly.
In addition, any single line comments are also removed, but any block comments (i.e. /* .. */ ) are retained as they might carry hints.