-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Media Display] Change aspect ratio to 3:4 for vertical media #1171
Comments
This was referenced May 21, 2024
mplorentz
changed the title
[Media Display] Change media gallery to 3:4 ratio when first item is vertical
[Media Display] Change aspect ratio to 3:4 for vertical media
May 21, 2024
Merged
joshuatbrown
added a commit
that referenced
this issue
Aug 22, 2024
joshuatbrown
added a commit
that referenced
this issue
Aug 27, 2024
@setch-l as with our other new media display work, this is behind the feature flag toggle in Settings > Enable new media display. Here are my suggested testing steps:
As we discussed, videos will all be shown in 3:4 (vertical) for now and until #1425 is complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
All horizontal or square media will be displayed in a 4:3 horizontal aspect ratio, but vertical media should be displayed at 3:4 when it is by itself. In a gallery the orientation of the first item will set the the aspect ratio to 3:4 or 4:3 for all items in the gallery.
This partially fulfills the following stories:
For now, all videos will default to 3:4 ratio until we implement #1425. Horizontal and vertical images will appear in the correct aspect ratio according to the stories.
The text was updated successfully, but these errors were encountered: