Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Media Display] Build new gallery view #1177

Closed
mplorentz opened this issue May 21, 2024 · 2 comments
Closed

[Media Display] Build new gallery view #1177

mplorentz opened this issue May 21, 2024 · 2 comments
Assignees

Comments

@mplorentz
Copy link
Member

mplorentz commented May 21, 2024

We are updating the look of our media gallery view Figma. This ticket includes the new styling of the gallery: the solid chrome under the media and the custom page dot indicator, and the change in aspect ratio from square to 4:3 (vertical media will be handled in #1171).

This ticket doesn't include the new styling for link metadata or the new viewers for the different media types, so the media displayed within the gallery will be the old Apple link previews until other tickets like #1164, #1166, and #1168.

@joshuatbrown
Copy link
Contributor

@setch-l We have this feature behind a feature flag that defaults to off. To turn it on so you can test, do the following:

  1. Navigate to Settings in Nos Staging
  2. Find "Enable new media display"
  3. Toggle it on
  4. Go back to the view and observe the custom page dot indicator, and the change in aspect ratio from square to 4:3

The new custom page dot indicator has an orange dot marking the selected page, so if you see the orange dot, you have "Enable new media display" turned on. If you see the white dot marking the page, the feature is turned off.

@setch-l
Copy link

setch-l commented Sep 5, 2024

This looks good.

@setch-l setch-l closed this as completed Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants