Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Media Display] Display images with new image viewer #1164

Closed
mplorentz opened this issue May 21, 2024 · 2 comments
Closed

[Media Display] Display images with new image viewer #1164

mplorentz opened this issue May 21, 2024 · 2 comments
Assignees

Comments

@mplorentz
Copy link
Member

mplorentz commented May 21, 2024

We are improving the way images are displayed alone or in a media gallery. In particular there is a new set of interactions when tapping the image. Instead of opening it in a web view there is a new fullscreen view that will appear that allows zooming and panning.

Images displayed should match these Figma designs and fulfill the following stories (detail):

  • Tapping a single image once, opens to full screen
  • Double tapping a full screen image will zoom to fit entire screen
  • Users can pan images in zoom screen view
  • Users can click x or swipe down to close image

We are leaving aspect ratio changes for #1171.

@setch-l
Copy link

setch-l commented Sep 5, 2024

This works except for swiping down to close the image, but I'm ok without that functionality. Nice work!

@joshuatbrown
Copy link
Contributor

@setch-l I'm surprised swiping down doesn't work for you. Well, unless you were zoomed in. If you're zoomed out, swipe down to dismiss should work. If you're zoomed in, swiping any direction just moves the image around.

@setch-l setch-l closed this as completed Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants