Show gallery in proper orientation when an image is the first link #1423
Conversation
joshuatbrown
changed the title
CHANGELOG.md
Outdated
| @@ -8,17 +8,21 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ### External | |||
There was a problem hiding this comment.
@mplorentz @martindsq @bryanmontz thoughts on this change to the CHANGELOG? Before I explain what it is, do these new headings make sense to you?
There was a problem hiding this comment.
At first I thought they were external vs internal contributors. But after looking more closely I think maybe external is things that users will notice and internal is not? So I guess I found the names a little confusing. Maybe "UX changes" and "Dev UX" changes or something like that would be more clear?
We have to do this kind of sorting before publishing the release notes anyway, so I guess it wouldn't hurt to do it here. Although I think it would be best to update the stamp_release fastlane lane to auto-generate these headers for consistency.
There was a problem hiding this comment.
Yeah, so the idea here is that "External" means things that we'll publish in our release notes on TestFlight. Since we don't want our users to see things like "Replaced hard-coded color values.", those notes would go under "Internal". I wonder if "Public" and "Internal" would work?
I'm all for updating stamp_release if/when we decide on a new approach, and I'd be happy to do that.
There was a problem hiding this comment.
Oh, I guess we could instead have a section called "Release Notes" and one called... I dunno, I keep coming up with "Internal". "Non Release Notes"? "Dev Notes"? "For the devs"? "Internal Notes"?
There was a problem hiding this comment.
I'm reverting the changes in this PR and will create a new PR with just CHANGELOG format changes. I'd still love to hear thoughts here or in the future PR.
Issues covered
#1171
Description
Shows gallery views in the proper orientation when an image is the first link in a post. If the first link is a portrait image, the entire gallery will display in portrait (3:4 aspect ratio). If the first link is a landscape or square image, the entire gallery will display in landscape (4:3 aspect ratio).
Doing this for video is more complicated; see #1425 for an explanation. We'll address landscape and portrait videos later; for now, Linda requested that we default to portrait for videos.
How to test
📣 Important! New media display is off by default and can only be toggled on in Settings for now. Follow the instructions below to turn it on.
onScreenshots/Video
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-08-27.at.14.09.39.mp4