Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: adapt new api for the executor package #22644

Merged
merged 17 commits into from
Feb 4, 2021
Merged

*: adapt new api for the executor package #22644

merged 17 commits into from
Feb 4, 2021

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Feb 1, 2021 •
edited
Loading

What problem does this PR solve?

Problem Summary: use new api introduced by #22499, #22546 and #22579 for the executor package. Some fmt.Printf are kept after the audit. It should be safe.

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@xhebox xhebox requested a review from a team as a code owner February 1, 2021 08:07
@xhebox xhebox requested review from lzmhhh123 and removed request for a team February 1, 2021 08:07
@github-actions github-actions bot added the sig/execution SIG execution label Feb 1, 2021
@xhebox xhebox force-pushed the injection_executor branch 10 times, most recently from 091c535 to 870ca77 Compare February 2, 2021 05:41
@xhebox
Copy link
Contributor Author

xhebox commented Feb 2, 2021

/run-all-tests

@xhebox xhebox mentioned this pull request Feb 2, 2021
Closed
@morgo
Copy link
Contributor

morgo commented Feb 2, 2021

@xhebox please fix conflicts :-)

@xhebox
*: FormatSQL and MustFormatSQL
7e381d8 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
*: show.go done
70eb4da 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
*: telemetry done
b62f58d 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
*: analyze.go done
f684031 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
*: ddl.go done
613d6e1 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
*: opt_rule_blacklist.go done
1143688 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
*: inspection_summary.go done
32e862f 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
*: brie.go done
c3934e0 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
*: inforschema_reader.go done
44834f1 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
*: grant.go & revoke.go done
ec779e5 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
*: trace.go done
6e5a8af 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
*: prepared.go done
d90b6aa 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
*: metrics_reader.go done
fc9233c 
Signed-off-by: xhe <xw897002528@gmail.com>
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 4, 2021
@bb7133
Copy link
Member

bb7133 commented Feb 4, 2021

/merge

@ti-srebot
Copy link
Contributor

@bb7133 Oops! auto merge is restricted to Committers of the SIG.See the corresponding SIG page for more information. Related SIG: execution(slack).

@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Feb 4, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 4, 2021
AilinKid
AilinKid reviewed Feb 4, 2021
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Feb 4, 2021
@AilinKid
Copy link
Contributor

AilinKid commented Feb 4, 2021

/merge

@ti-srebot
Copy link
Contributor

@AilinKid Oops! auto merge is restricted to Committers of the SIG.See the corresponding SIG page for more information. Related SIG: execution(slack).

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 4172f47 into pingcap:master Feb 4, 2021
@xhebox xhebox deleted the injection_executor branch February 20, 2021 05:56
@xhebox xhebox restored the injection_executor branch February 20, 2021 05:57
xhebox added a commit to xhebox/tidb that referenced this pull request Feb 23, 2021
@xhebox
*: adapt new api for the executor package (pingcap#22644)
619d70e 
Signed-off-by: xhe <xw897002528@gmail.com>
This was referenced Feb 23, 2021
Merged
Merged
Merged
ti-chi-bot pushed a commit that referenced this pull request Feb 25, 2021
@xhebox
*: adapt new api for the executor package (#22644) (#22885)
eba296b
ti-chi-bot pushed a commit that referenced this pull request Feb 25, 2021
@xhebox
*: adapt new api for the executor package (#22644) (#22888)
29251c8
ti-chi-bot pushed a commit that referenced this pull request Feb 25, 2021
@xhebox
*: adapt new api for the executor package (#22644) (#22889)
f6e8cb4
xhebox added a commit to xhebox/tidb that referenced this pull request Mar 8, 2021
@xhebox
*: adapt new api for the executor package (pingcap#22644)
697ca61 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox mentioned this pull request Mar 8, 2021
Merged
ti-chi-bot pushed a commit that referenced this pull request Mar 17, 2021
@xhebox
*: adapt new api for the executor package (#22644) (#23156)
f055086
@xhebox xhebox deleted the injection_executor branch April 2, 2021 04:32
@jackysp jackysp mentioned this pull request Apr 7, 2021
Merged
This was referenced Apr 12, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgo morgo morgo left review comments

@bb7133 bb7133 bb7133 left review comments

@AilinKid AilinKid AilinKid left review comments

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

Assignees
No one assigned
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@xhebox @morgo @ti-srebot @bb7133 @XuHuaiyu @AilinKid @wjhuang2016