Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix show table status for the database with upper-cased name #23896

Merged
merged 15 commits into from
Apr 12, 2021

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Apr 7, 2021

Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:
show table status does not work for a database with upper-cased name.

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:
Fix it. Introduced by #22644

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Release note

  • fix show table status for the database with upper-cased name.

Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@jackysp jackysp requested a review from a team as a code owner April 7, 2021 09:13
@jackysp jackysp requested review from XuHuaiyu and removed request for a team April 7, 2021 09:13
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 7, 2021
@jackysp jackysp added the sig/execution SIG execution label Apr 7, 2021
@jackysp jackysp requested review from xhebox and morgo April 7, 2021 09:14
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 7, 2021
@xhebox
Copy link
Contributor

xhebox commented Apr 7, 2021

/cc @tiancaiamao

Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 7, 2021
@jackysp
Copy link
Member Author

jackysp commented Apr 8, 2021

PTAL @morgo , thx!

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xhebox
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 8, 2021
@xiongjiwei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 74a8d65

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 8, 2021
@morgo
Copy link
Contributor

morgo commented Apr 8, 2021

/LGTM

Long term this should be implemented with collations of course.

@jackysp
Copy link
Member Author

jackysp commented Apr 9, 2021

/merge

@jackysp
Copy link
Member Author

jackysp commented Apr 9, 2021

Seems CI/bot is stopped.

@xhebox
Copy link
Contributor

xhebox commented Apr 11, 2021

/run-all-tests

@jackysp
Copy link
Member Author

jackysp commented Apr 12, 2021

[2021-04-11T14:32:13.821Z] FAIL: explainfor_test.go:73: testSerialSuite.TestExplainFor
[2021-04-11T14:32:13.821Z] 
[2021-04-11T14:32:13.821Z] explainfor_test.go:121:
[2021-04-11T14:32:13.821Z]     check()
[2021-04-11T14:32:13.821Z] explainfor_test.go:114:
[2021-04-11T14:32:13.821Z]     c.Assert(buf.String(), Matches, ""+
[2021-04-11T14:32:13.821Z]         "TableReader_5 10000.00 0 root  time:.*, loops:1, cop_task: {num:.*, max:.*, proc_keys: 0, rpc_num: 1, rpc_time:.*} data:TableFullScan_4 N/A N/A\n"+
[2021-04-11T14:32:13.821Z]         "└─TableFullScan_4 10000.00 0 cop.* table:t1 tikv_task:{time:.*, loops:0} keep order:false, stats:pseudo N/A N/A")
[2021-04-11T14:32:13.821Z] ... value string = "" +
[2021-04-11T14:32:13.821Z] ...     "TableReader_5 10000.00 0 root  time:3.03ms, loops:1, cop_task: {num: 1, max: 1.68ms, proc_keys: 0, tot_proc: 1ms, rpc_num: 1, rpc_time: 1.27ms, copr_cache_hit_ratio: 0.00} data:TableFullScan_4 N/A N/A\n" +
[2021-04-11T14:32:13.821Z] ...     "└─TableFullScan_4 10000.00 0 cop[tikv] table:t1 tikv_task:{time:0s, loops:0} keep order:false, stats:pseudo N/A N/A"
[2021-04-11T14:32:13.821Z] ... regex string = "" +
[2021-04-11T14:32:13.821Z] ...     "TableReader_5 10000.00 0 root  time:.*, loops:1, cop_task: {num:.*, max:.*, proc_keys: 0, rpc_num: 1, rpc_time:.*} data:TableFullScan_4 N/A N/A\n" +
[2021-04-11T14:32:13.821Z] ...     "└─TableFullScan_4 10000.00 0 cop.* table:t1 tikv_task:{time:.*, loops:0} keep order:false, stats:pseudo N/A N/A"

Test failed, not related to this PR.

@jackysp
Copy link
Member Author

jackysp commented Apr 12, 2021

/merge

@jackysp
Copy link
Member Author

jackysp commented Apr 12, 2021

/run-unit-test

2 similar comments
@jackysp
Copy link
Member Author

jackysp commented Apr 12, 2021

/run-unit-test

@jackysp
Copy link
Member Author

jackysp commented Apr 12, 2021

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit dbd5a36 into pingcap:master Apr 12, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 12, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #23958

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 12, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #23959

@tiancaiamao
Copy link
Contributor

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.0 sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants