-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix show table status
for the database with upper-cased name
#23896
Conversation
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cc @tiancaiamao |
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
PTAL @morgo , thx! |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 74a8d65
|
/LGTM Long term this should be implemented with collations of course. |
/merge |
Seems CI/bot is stopped. |
/run-all-tests |
Test failed, not related to this PR. |
/merge |
/run-unit-test |
2 similar comments
/run-unit-test |
/run-unit-test |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #23958 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.0 in PR #23959 |
/merge |
Signed-off-by: Shuaipeng Yu jackysp@gmail.com
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
show table status
does not work for a database with upper-cased name.What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Fix it. Introduced by #22644
Related changes
Check List
Tests
Release note
show table status
for the database with upper-cased name.