Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: introduce FormatSQL and MustFormatSQL #22674

Closed
wants to merge 1 commit into from
Closed

*: introduce FormatSQL and MustFormatSQL #22674

wants to merge 1 commit into from

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Feb 2, 2021

What problem does this PR solve?

Problem Summary: To target some flexible & dynamic SQL. It is extracted from #22644, one example case here

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@xhebox
*: FormatSQL and MustFormatSQL
78b2118 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from a team as a code owner February 2, 2021 09:43
@xhebox xhebox requested review from wshwsh12 and removed request for a team February 2, 2021 09:43
@github-actions github-actions bot added the sig/execution SIG execution label Feb 2, 2021
@xhebox xhebox mentioned this pull request Feb 3, 2021
Merged
@xhebox
Copy link
Contributor Author

xhebox commented Feb 19, 2021

It is one sub commit from #22644. It is expected to be merged after #22644, but #22644 got merged.

@xhebox xhebox closed this Feb 19, 2021
@xhebox xhebox deleted the injection_format branch February 20, 2021 05:55
@xhebox xhebox restored the injection_format branch February 23, 2021 02:27
@xhebox xhebox deleted the injection_format branch April 2, 2021 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

@AilinKid AilinKid Awaiting requested review from AilinKid

@morgo morgo Awaiting requested review from morgo

Assignees
No one assigned
Labels
sig/execution SIG execution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xhebox