Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix show table status for the database with upper-cased name (#23896) #23958

Merged
merged 6 commits into from
May 6, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Apr 12, 2021

cherry-pick #23896 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/23958

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/23958:release-4.0-dbd5a3622a53

Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:
show table status does not work for a database with upper-cased name.

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:
Fix it. Introduced by #22644

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Release note

  • fix show table status for the database with upper-cased name.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/4.0-cherry-pick labels Apr 12, 2021
@ti-srebot ti-srebot added this to the v4.0.11 milestone Apr 12, 2021
@ti-srebot
Copy link
Contributor Author

@jackysp you're already a collaborator in bot's repo.

Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 12, 2021
@jackysp
Copy link
Member

jackysp commented Apr 15, 2021

PTAL @morgo @xiongjiwei

@morgo
Copy link
Contributor

morgo commented Apr 15, 2021

/LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • morgo
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 15, 2021
@morgo
Copy link
Contributor

morgo commented Apr 15, 2021

/run-check_dev

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2021
@jackysp
Copy link
Member

jackysp commented Apr 16, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 38ac074

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2021
@tiancaiamao
Copy link
Contributor

/run-all-tests

@jackysp
Copy link
Member

jackysp commented Apr 26, 2021

/run-check_release_note

@jackysp
Copy link
Member

jackysp commented Apr 26, 2021

/run-integration-br-test

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 30, 2021
@zhouqiang-cl
Copy link
Contributor

/run-integration-br-test

@zhouqiang-cl
Copy link
Contributor

/merge

@jackysp
Copy link
Member

jackysp commented May 6, 2021

/run-check_dev

@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 0d4f5de into pingcap:release-4.0 May 6, 2021
@zhouqiang-cl zhouqiang-cl modified the milestones: v4.0.11, v4.0.13 May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants