Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(debug-api): support pagination for ddl history #1584

Merged
merged 2 commits into from
Aug 30, 2023
Merged

feat(debug-api): support pagination for ddl history #1584

merged 2 commits into from
Aug 30, 2023

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Aug 30, 2023 •
edited
Loading

What Did

This PR supports to download the ddl history by pagination to avoid TiDB OOM.

Preview

image

@ti-chi-bot ti-chi-bot bot requested a review from Renkai August 30, 2023 02:25
@netlify
Copy link

netlify bot commented Aug 30, 2023 •
edited
Loading

✅ Deploy Preview for tidb-dashboard ready!

Name Link
🔨 Latest commit afaec37
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/64eea9326bac630008a60ec5
😎 Deploy Preview https://deploy-preview-1584--tidb-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ti-chi-bot ti-chi-bot bot added the size/M label Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023 •
edited
Loading

Codecov Report

Merging #1584 (afaec37) into master (949927a) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1584      +/-   ##
==========================================
+ Coverage   24.61%   24.65%   +0.03%     
==========================================
  Files         168      168              
  Lines       15135    15142       +7     
==========================================
+ Hits         3726     3733       +7     
  Misses      11135    11135              
  Partials      274      274
Flag Coverage Δ
backend_integration 9.12% <100.00%> (+0.01%) ⬆️
backend_ut 26.57% <62.50%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 949927a...afaec37. Read the comment docs.

shhdgit
shhdgit approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@shhdgit shhdgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we don't need to provide DDL History - All anymore?

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 30, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shhdgit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-30 02:30:07.385675119 +0000 UTC m=+1894171.934691091: ☑️ agreed by shhdgit.

@ti-chi-bot ti-chi-bot bot added the approved label Aug 30, 2023
@ti-chi-bot ti-chi-bot bot merged commit db0052c into master Aug 30, 2023
@ti-chi-bot ti-chi-bot bot deleted the chore/limit-ddl-history branch August 30, 2023 02:32
@baurine
Copy link
Collaborator Author

baurine commented Aug 30, 2023

So we don't need to provide DDL History - All anymore?

Yep, I think so, according the discussion. And if they really want to download the all, they can set a very large limit value.

baurine added a commit that referenced this pull request Sep 11, 2023
@baurine
feat(debug-api): support pagination for ddl history (#1584)
30bbd5c
baurine added a commit that referenced this pull request Sep 11, 2023
@baurine @shhdgit
@SabaPing @nolouch @mornyx
Release v2023.09.11.01 [skip pd_pr] (#1588)
22add1e 
* feat(execution-plan): refine execution plan (#1561)

* chore(binary-plan): truncate long operator info for execution plan (#1565)

* feat: fix and refine execution plan (#1568)

* chore(binary-plan): show eye icon to hide column when hover (#1574)

* bump: i18next (#1575)

* Remove PNPM_INSTALL_TAGS=--offline (#1578)

* chore: upgrade node from 16 to 18, pnpm from 7 to 8 (#1580)

* feat(conprof): show conprof download link for TiCDC (#1581)

* keyvisual: use scanRegions instead of fetch all regions (#1579)

* feat(resource-control): show resource control entry for clinic (#1582)

* feat(debug-api): support pagination for ddl history (#1584)

* feat(security): encrypt login password (#1583)

* chore: update swaggo (#1585)

* test(login): fix login integration test (#1587)

* update release version to 2023.09.11.1

---------

Co-authored-by: Suhaha <jklopsdfw@gmail.com>
Co-authored-by: Yifan Xu <xuyifan02@pingcap.com>
Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: Yexiang Zhang <mornyx.z@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shhdgit shhdgit shhdgit approved these changes

@Renkai Renkai Awaiting requested review from Renkai

Assignees
No one assigned
Labels
approved area/frontend lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baurine @shhdgit