Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyvisual: use scanRegions instead of fetch all regions #1579

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

nolouch
Copy link
Member

@nolouch nolouch commented Aug 21, 2023

If deploy tidb-dashboard independently, key visual will use pd API to fetch regions. here is an improvement about it.
PD memory:
before
image

after
image

test with new apis:
image

@ti-chi-bot ti-chi-bot bot requested a review from Renkai August 21, 2023 08:35
@CLAassistant
Copy link

CLAassistant commented Aug 21, 2023

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Aug 21, 2023

Deploy Preview for tidb-dashboard ready!

Name Link
🔨 Latest commit 5b1cdfe
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/64e5a0b4078dc900089d2ab3
😎 Deploy Preview https://deploy-preview-1579--tidb-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ti-chi-bot ti-chi-bot bot added the size/M label Aug 21, 2023
@netlify
Copy link

netlify bot commented Aug 21, 2023

Deploy Preview for tidb-dashboard-for-dbaas failed.

Name Link
🔨 Latest commit 8c44f55
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard-for-dbaas/deploys/64e322a01956bc00099d8acd

Signed-off-by: nolouch <nolouch@gmail.com>
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #1579 (5b1cdfe) into master (3fcd2e2) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1579      +/-   ##
==========================================
- Coverage   24.68%   24.61%   -0.07%     
==========================================
  Files         168      168              
  Lines       15097    15135      +38     
==========================================
  Hits         3726     3726              
- Misses      11097    11135      +38     
  Partials      274      274              
Flag Coverage Δ
backend_integration 9.07% <0.00%> (-0.07%) ⬇️
backend_ut 26.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fcd2e2...5b1cdfe. Read the comment docs.

@baurine baurine requested review from shhdgit and mornyx August 23, 2023 03:29
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 23, 2023

@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 23, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 23, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-23 07:44:13.467281909 +0000 UTC m=+1308218.016297881: ☑️ agreed by baurine.

@ti-chi-bot ti-chi-bot bot added the approved label Aug 23, 2023
@baurine
Copy link
Collaborator

baurine commented Aug 23, 2023

/lgtm

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baurine, mornyx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 1616d48 into pingcap:master Aug 23, 2023
11 of 14 checks passed
@nolouch nolouch deleted the Imporve-KeyViz-Data branch August 23, 2023 07:54
baurine added a commit that referenced this pull request Sep 11, 2023
* feat(execution-plan): refine execution plan (#1561)

* chore(binary-plan): truncate long operator info for execution plan (#1565)

* feat: fix and refine execution plan (#1568)

* chore(binary-plan): show eye icon to hide column when hover (#1574)

* bump: i18next (#1575)

* Remove PNPM_INSTALL_TAGS=--offline (#1578)

* chore: upgrade node from 16 to 18, pnpm from 7 to 8 (#1580)

* feat(conprof): show conprof download link for TiCDC (#1581)

* keyvisual: use scanRegions instead of fetch all regions (#1579)

* feat(resource-control): show resource control entry for clinic (#1582)

* feat(debug-api): support pagination for ddl history (#1584)

* feat(security): encrypt login password (#1583)

* chore: update swaggo (#1585)

* test(login): fix login integration test (#1587)

* update release version to 2023.09.11.1

---------

Co-authored-by: Suhaha <jklopsdfw@gmail.com>
Co-authored-by: Yifan Xu <xuyifan02@pingcap.com>
Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: Yexiang Zhang <mornyx.z@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants