Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conprof): show conprof download link for TiCDC #1581

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Aug 23, 2023

What Did

This PR supports to view TiCDC conprof status.

TODO: test compatibility with old versions (7.1, 6.5. 6.1)

Test

Test in 7.3.0, 7.1.0, 6.5.3, 6.1.0.

6.1.0 doesn't show TiCDC component in conprof, because the ngm of this version doesn't support TiCDC.

others all show TiCDC component in conprof.

Preview

Run dev env:

$ tiup playground 
$ tiup cdc server --addr 127.0.0.1:8301

The cluster and cdc are both 7.3.0 version.

image

image

Note: in my test environment, the ngm can't get the TiCDC profiles successfully, don't know why, so in the above screenshot, the status is Partial Finished, and in the detail page, the status for TiCDC is Error, clicking the Error Information, it will show the error reason in the modal.

@ti-chi-bot ti-chi-bot bot requested a review from Renkai August 23, 2023 01:26
@netlify
Copy link

netlify bot commented Aug 23, 2023

Deploy Preview for tidb-dashboard ready!

Name Link
🔨 Latest commit f0a6a9d
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/64e5608afe010c000869f3c7
😎 Deploy Preview https://deploy-preview-1581--tidb-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ti-chi-bot ti-chi-bot bot added the size/M label Aug 23, 2023
@baurine baurine force-pushed the feat/support-ticdc-for-conprof branch from 4ae5b2e to f0a6a9d Compare August 23, 2023 01:27
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #1581 (f0a6a9d) into master (ae6e959) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1581   +/-   ##
=======================================
  Coverage   24.68%   24.68%           
=======================================
  Files         168      168           
  Lines       15097    15097           
=======================================
  Hits         3726     3726           
  Misses      11097    11097           
  Partials      274      274           
Flag Coverage Δ
backend_integration 9.14% <ø> (ø)
backend_ut 26.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58349be...f0a6a9d. Read the comment docs.

@baurine baurine requested review from shhdgit and mornyx August 23, 2023 01:38
@shhdgit
Copy link
Member

shhdgit commented Aug 23, 2023

LGTM, but why the second pic shows the connection refused? What does that mean?

@baurine
Copy link
Collaborator Author

baurine commented Aug 23, 2023

LGTM, but why the second pic shows the connection refused? What does that mean?

It's the ngm service error, I don't know why it doesn't work normally, need @mornyx 's help. But for frontend, it shows the correct content from the API.

@mornyx
Copy link
Collaborator

mornyx commented Aug 23, 2023

I successfully deployed on the feature branch and no errors were repeated. I think we can assume that this feature is OK, the problem is the environment.

image
image
image

So LGTM

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 23, 2023

@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 23, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mornyx
Once this PR has been reviewed and has the lgtm label, please ask for approval from baurine. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@baurine baurine merged commit 3fcd2e2 into master Aug 23, 2023
14 checks passed
@baurine baurine deleted the feat/support-ticdc-for-conprof branch August 23, 2023 06:00
baurine added a commit that referenced this pull request Sep 11, 2023
* feat(execution-plan): refine execution plan (#1561)

* chore(binary-plan): truncate long operator info for execution plan (#1565)

* feat: fix and refine execution plan (#1568)

* chore(binary-plan): show eye icon to hide column when hover (#1574)

* bump: i18next (#1575)

* Remove PNPM_INSTALL_TAGS=--offline (#1578)

* chore: upgrade node from 16 to 18, pnpm from 7 to 8 (#1580)

* feat(conprof): show conprof download link for TiCDC (#1581)

* keyvisual: use scanRegions instead of fetch all regions (#1579)

* feat(resource-control): show resource control entry for clinic (#1582)

* feat(debug-api): support pagination for ddl history (#1584)

* feat(security): encrypt login password (#1583)

* chore: update swaggo (#1585)

* test(login): fix login integration test (#1587)

* update release version to 2023.09.11.1

---------

Co-authored-by: Suhaha <jklopsdfw@gmail.com>
Co-authored-by: Yifan Xu <xuyifan02@pingcap.com>
Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: Yexiang Zhang <mornyx.z@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants