feat(execution-plan): refine execution plan #1561
Conversation
❌ Deploy Preview for tidb-dashboard failed.
|
❌ Deploy Preview for tidb-dashboard-for-dbaas failed.
|
baurine
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1561 +/- ##
==========================================
- Coverage 27.25% 24.78% -2.48%
==========================================
Files 93 168 +75
Lines 10097 15003 +4906
==========================================
+ Hits 2752 3718 +966
- Misses 7165 11014 +3849
- Partials 180 271 +91
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
baurine
force-pushed
the
feat/refine-execution-plan
branch
from
1457914
to
f20e7a5
Compare
baurine
force-pushed
the
feat/refine-execution-plan
branch
from
f20e7a5
to
8c39528
Compare
| if err != nil { | ||
| err = db. | ||
| Select("*, (UNIX_TIMESTAMP(Time) + 0E0) AS timestamp"). | ||
| Where("Digest = ?", req.Digest). | ||
| Where("Time = FROM_UNIXTIME(?)", req.Timestamp). | ||
| Where("Conn_id = ?", req.ConnectID). | ||
| First(&result).Error | ||
| } |
There was a problem hiding this comment.
Is it to eliminate any errors generated by tidb_decode_binary_plan? What errors does it generate?
There was a problem hiding this comment.
tidb_decode_binary_plan method may not exist in the old tidb version (it is, right? I'm not sure now), so it's for compatibility. theoretically, the latest tidb-dashboard version should work for every tidb version.
ui/packages/tidb-dashboard-lib/src/apps/Statement/pages/Detail/PlanDetail.tsx
Show resolved
Hide resolved
|
Go part LTGM |
|
@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mornyx, shhdgit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* feat(execution-plan): refine execution plan (#1561) * chore(binary-plan): truncate long operator info for execution plan (#1565) * feat: fix and refine execution plan (#1568) * chore(binary-plan): show eye icon to hide column when hover (#1574) * bump: i18next (#1575) * Remove PNPM_INSTALL_TAGS=--offline (#1578) * chore: upgrade node from 16 to 18, pnpm from 7 to 8 (#1580) * feat(conprof): show conprof download link for TiCDC (#1581) * keyvisual: use scanRegions instead of fetch all regions (#1579) * feat(resource-control): show resource control entry for clinic (#1582) * feat(debug-api): support pagination for ddl history (#1584) * feat(security): encrypt login password (#1583) * chore: update swaggo (#1585) * test(login): fix login integration test (#1587) * update release version to 2023.09.11.1 --------- Co-authored-by: Suhaha <jklopsdfw@gmail.com> Co-authored-by: Yifan Xu <xuyifan02@pingcap.com> Co-authored-by: ShuNing <nolouch@gmail.com> Co-authored-by: Yexiang Zhang <mornyx.z@gmail.com>
What Did
explain analyzeresult.Preview
Before
After