Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor edits to README #583

Merged
merged 1 commit into from
May 6, 2019
Merged

Minor edits to README #583

merged 1 commit into from
May 6, 2019

Conversation

ceohockey60
Copy link
Contributor

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

@ceohockey60 ceohockey60 requested a review from QueenyJin May 6, 2019 17:09
QueenyJin
QueenyJin approved these changes May 6, 2019
View reviewed changes
Copy link

@QueenyJin QueenyJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QueenyJin QueenyJin merged commit 4f46072 into master May 6, 2019
@QueenyJin QueenyJin deleted the ceohockey60-patch-1 branch May 6, 2019 17:11
IANTHEREAL pushed a commit that referenced this pull request May 7, 2019
@WangXiangUSTC @IANTHEREAL
release 3.0 rebase master (#587)
8ff1c75 
* drainer/: Fix when pk is handle and value overflow int64 (#573)

* arbiter: Refactor and add more unit tests (#570)

* More tests for arbiter

* Log os.Hostname error

* drainer: Refactor, eliminate duplicate code by introducing a taskGroup (#572)

* Refactor, eliminate duplicate code by introducing a taskGroup

* Use zap.Stack directly

* binlogctl: refine log output when use help command (#580)

* Minor edits to README (#583)

* drainer: Refactor and add unit tests (#571)

* Add tests for drainer

* Use DeepEquals to simplify map testing

* Just import context

* Use Equals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QueenyJin QueenyJin QueenyJin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ceohockey60 @QueenyJin