Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drainer/: Fix when pk is handle and value overflow int64 #573

Merged
merged 2 commits into from
Apr 30, 2019
Merged

drainer/: Fix when pk is handle and value overflow int64 #573

merged 2 commits into from
Apr 30, 2019

Conversation

july2993
Copy link
Contributor

@july2993 july2993 commented Apr 29, 2019 •
edited
Loading

What problem does this PR solve?

Fix when pk is handle and value overflow int64
can fix https://internal.pingcap.net/jira/browse/TOOL-1132

before this pr:

mysql> create table pk(`id` bigint(20) UNSIGNED NOT NULL primary key);
insert into pk(id) values(18446744073709551615);  // this will failed we insert -1 at downstream

note uint64(int64(-1)) = 18446744073709551615

the test added also fix https://internal.pingcap.net/jira/browse/TOOL-1139

What is changed and how it works?

change to uint64 from int64 when the pk column is unsigned

Check List

Tests

  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@july2993
Copy link
Contributor Author

/run-all-tests

@july2993 july2993 requested review from suzaku and csuzhangxc April 29, 2019 11:13
@IANTHEREAL
Copy link
Collaborator

I think the important thing is what's nature the issue implies, Is it that a single Datum object cannot indicate the real type of column data? It seems we must need the help of column type to correctly interpret a column data

suzaku
suzaku reviewed Apr 30, 2019
View reviewed changes
tests/dailytest/case.go Outdated Show resolved Hide resolved
tests/dailytest/case.go Outdated Show resolved Hide resolved
csuzhangxc
csuzhangxc reviewed Apr 30, 2019
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suzaku
Copy link
Contributor

suzaku commented Apr 30, 2019

LGTM

IANTHEREAL
IANTHEREAL approved these changes Apr 30, 2019
View reviewed changes
Copy link
Collaborator

@IANTHEREAL IANTHEREAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993 july2993 merged commit 825e88a into master Apr 30, 2019
@july2993 july2993 deleted the hjh/fix_pk_type branch April 30, 2019 07:29
@july2993 july2993 mentioned this pull request Apr 30, 2019
Merged
IANTHEREAL pushed a commit that referenced this pull request May 7, 2019
@WangXiangUSTC @IANTHEREAL
release 3.0 rebase master (#587)
8ff1c75 
* drainer/: Fix when pk is handle and value overflow int64 (#573)

* arbiter: Refactor and add more unit tests (#570)

* More tests for arbiter

* Log os.Hostname error

* drainer: Refactor, eliminate duplicate code by introducing a taskGroup (#572)

* Refactor, eliminate duplicate code by introducing a taskGroup

* Use zap.Stack directly

* binlogctl: refine log output when use help command (#580)

* Minor edits to README (#583)

* drainer: Refactor and add unit tests (#571)

* Add tests for drainer

* Use DeepEquals to simplify map testing

* Just import context

* Use Equals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@suzaku suzaku suzaku left review comments

@IANTHEREAL IANTHEREAL IANTHEREAL approved these changes

Assignees
No one assigned
Labels
priority/important status/LGT2 type/bug-fix type/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@july2993 @IANTHEREAL @suzaku @csuzhangxc