-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arbiter: Refactor and add more unit tests #570
Conversation
/run-all-tests |
1 similar comment
/run-all-tests |
/run-all-tests |
1 similar comment
/run-all-tests |
c.Assert(ld.safe, IsFalse) | ||
} | ||
|
||
func (s *testNewServerSuite) TestCreateMetricCli(c *C) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about this test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean?
LGTM |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
* drainer/: Fix when pk is handle and value overflow int64 (#573) * arbiter: Refactor and add more unit tests (#570) * More tests for arbiter * Log os.Hostname error * drainer: Refactor, eliminate duplicate code by introducing a taskGroup (#572) * Refactor, eliminate duplicate code by introducing a taskGroup * Use zap.Stack directly * binlogctl: refine log output when use help command (#580) * Minor edits to README (#583) * drainer: Refactor and add unit tests (#571) * Add tests for drainer * Use DeepEquals to simplify map testing * Just import context * Use Equals
What problem does this PR solve?
Fix Jira Issue
What is changed and how it works?
Improve test coverage: 57.2% -> 76.2%
Check List
Tests
Code changes
Side effects
Related changes