drainer: Refactor, eliminate duplicate code by introducing a taskGroup #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
IANTHEREAL
reviewed
Apr 29, 2019
| func (s *Server) heartbeat(ctx context.Context) <-chan error { | ||
| errc := make(chan error, 1) | ||
| err := s.updateStatus() |
There was a problem hiding this comment.
the change is a little different. Before the change, calling heartbeat would must execute updateStatus, now it's not sure
There was a problem hiding this comment.
heartbeat is only called in Start and Start calls updateStatus right before heartbeat, so even when the goroutine scheduler decides not to run another updateStatus immediately, it makes little difference.
|
Rest LGTM. Good Job! keep to clear codes |
|
LGTM |
|
/run-all-tests |
kennytm
approved these changes
Apr 30, 2019
IANTHEREAL
pushed a commit
that referenced
this pull request
May 7, 2019
* drainer/: Fix when pk is handle and value overflow int64 (#573) * arbiter: Refactor and add more unit tests (#570) * More tests for arbiter * Log os.Hostname error * drainer: Refactor, eliminate duplicate code by introducing a taskGroup (#572) * Refactor, eliminate duplicate code by introducing a taskGroup * Use zap.Stack directly * binlogctl: refine log output when use help command (#580) * Minor edits to README (#583) * drainer: Refactor and add unit tests (#571) * Add tests for drainer * Use DeepEquals to simplify map testing * Just import context * Use Equals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The code used by
drainer.Serverto start stuff likecollectorandsyncerare almost identical.
What is changed and how it works?
Create a wrapper of
sync.WaitGroupthat's similar toerrgroup, butprovide a
GoNoPanicmethod that automatically recover from goroutine panicsand log the error.
Check List
Tests
Code changes
Side effects
Related changes