This repository was archived by the owner on Jan 3, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
Fix broken link in shard-merge-best-practices.md
#899
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
* Make the description clearer on how to use the two configs * make all the Chinese expressions clearer * Update task-configuration-guide.md * address comments * Update key-features.md * Apply suggestions from code review * address comments
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Member
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area/best-practices
Adds or updates TiDB best practices.
first-time-contributor
Indicates that the PR was contributed by an external member and is a first-time contributor.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
translation/no-need
The changes in this PR don't need to be translated.
type/bug-fix
Fixes typos or wrong format.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First-time contributors' checklist
What is changed, added, or deleted? (Required)
Close #898. Fix broken link in
shard-merge-best-practices.md.Which DM version(s) do your changes apply to? (Required)
Since December 23, 2021, the TiDB DM documentation in the master branch has been merged to TiDB documentation by #8042 and #7317. To create a PR for TiDB DM versions later than v5.3, either go to TiDB English documentation repository or Chinese documentation repository.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?