Skip to content
This repository was archived by the owner on Jan 3, 2025. It is now read-only.

Conversation

@Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented May 23, 2022

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Close #898. Fix broken link in shard-merge-best-practices.md.

Which DM version(s) do your changes apply to? (Required)

Since December 23, 2021, the TiDB DM documentation in the master branch has been merged to TiDB documentation by #8042 and #7317. To create a PR for TiDB DM versions later than v5.3, either go to TiDB English documentation repository or Chinese documentation repository.

  • v5.3 (TiDB DM 5.3 versions)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added area/best-practices Adds or updates TiDB best practices. translation/no-need The changes in this PR don't need to be translated. type/bug-fix Fixes typos or wrong format. labels May 23, 2022
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label May 23, 2022
@CLAassistant
Copy link

CLAassistant commented May 23, 2022

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot requested a review from shichun-0415 May 23, 2022 02:25
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 23, 2022
@Oreoxmt Oreoxmt changed the base branch from master to release-5.3 May 23, 2022 03:55
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2022
@Oreoxmt Oreoxmt closed this May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/best-practices Adds or updates TiDB best practices. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/no-need The changes in this PR don't need to be translated. type/bug-fix Fixes typos or wrong format.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken Link Detected