Skip to content
This repository was archived by the owner on Jan 3, 2025. It is now read-only.

Conversation

@hfxsd
Copy link
Contributor

@hfxsd hfxsd commented Dec 10, 2021

changed github.com/pingcap/ticdc to github.com/pingcap/tiflow

First-time contributors' checklist

What is changed, added, or deleted? (Required)

changed github.com/pingcap/ticdc to github.com/pingcap/tiflow

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.3 (TiDB DM 5.3 versions)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

changed github.com/pingcap/ticdc to github.com/pingcap/tiflow
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@hfxsd hfxsd requested review from TomShawn and removed request for shichun-0415 December 10, 2021 07:05
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 10, 2021
@hfxsd hfxsd requested review from lilin90, shichun-0415 and zier-one and removed request for shichun-0415 December 10, 2021 07:05
@hfxsd hfxsd self-assigned this Dec 10, 2021
@hfxsd hfxsd added the translation/no-need The changes in this PR don't need to be translated. label Dec 10, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Dec 10, 2021
@hfxsd hfxsd added the area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. label Dec 10, 2021
@hfxsd hfxsd requested a review from qiancai December 10, 2021 07:41
@hfxsd hfxsd added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2021
hfxsd and others added 2 commits December 20, 2021 14:42
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
@hfxsd hfxsd removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2021
@hfxsd
Copy link
Contributor Author

hfxsd commented Dec 20, 2021

/merge
/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 20, 2021
@ti-chi-bot
Copy link
Member

@hfxsd: These labels are not set on the issue: status/lgt1.

Details

In response to this:

/merge
/remove-status LGT1
/status LGT2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 7c1107b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 20, 2021
@hfxsd
Copy link
Contributor Author

hfxsd commented Dec 20, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit 7b5f6e7 into pingcap:master Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/no-need The changes in this PR don't need to be translated.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants