Skip to content
This repository was archived by the owner on Jan 3, 2025. It is now read-only.

zh/en: add 5.3.0 release note #827

Merged
ti-chi-bot merged 16 commits into from
Nov 24, 2021
Merged

zh/en: add 5.3.0 release note #827

ti-chi-bot merged 16 commits into from
Nov 24, 2021

Conversation

@Ehco1996
Copy link
Contributor

@Ehco1996 Ehco1996 commented Nov 17, 2021

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.3 (TiDB DM 5.3 versions)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 17, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Liuxiaozhen12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 17, 2021
@Ehco1996
Copy link
Contributor Author

Ehco1996 commented Nov 17, 2021

/translation no-need
/status PTAL

@ti-chi-bot ti-chi-bot added translation/no-need The changes in this PR don't need to be translated. status/PTAL This PR is ready for reviewing. and removed missing-translation-status This PR does not have translation status info. labels Nov 17, 2021
Ehco1996
Ehco1996 commented Nov 17, 2021
View reviewed changes
glorv
glorv reviewed Nov 17, 2021
View reviewed changes
Ehco1996 and others added 2 commits November 17, 2021 20:28
@Ehco1996 @glorv
Apply suggestions from code review
9f0382c 
Co-authored-by: glorv <glorvs@163.com>
@Ehco1996
address comment
1e995e6
lance6716
lance6716 reviewed Nov 18, 2021
View reviewed changes
Ehco1996 and others added 2 commits November 18, 2021 11:05
@Ehco1996 @lance6716
Apply suggestions from code review
3a24389 
Co-authored-by: lance6716 <lance6716@gmail.com>
@Ehco1996
apply suggestions to en
6eef020
lance6716
lance6716 reviewed Nov 18, 2021
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for chinese part.

waiting a LGTM from doc team

glorv
glorv reviewed Nov 18, 2021
View reviewed changes
Ehco1996 and others added 2 commits November 18, 2021 14:46
Liuxiaozhen12
Liuxiaozhen12 reviewed Nov 18, 2021
View reviewed changes
@Ehco1996 @Liuxiaozhen12
Update zh/releases/5.3.0.md
21f4370 
Co-authored-by: Liuxiaozhen12 <82579298+Liuxiaozhen12@users.noreply.github.com>
Liuxiaozhen12
Liuxiaozhen12 reviewed Nov 18, 2021
View reviewed changes
Liuxiaozhen12
Liuxiaozhen12 reviewed Nov 18, 2021
View reviewed changes
Liuxiaozhen12
Liuxiaozhen12 approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@Liuxiaozhen12 Liuxiaozhen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 18, 2021
@Ehco1996 @Liuxiaozhen12
Apply suggestions from code review
31805f4 
Co-authored-by: Liuxiaozhen12 <82579298+Liuxiaozhen12@users.noreply.github.com>
@Liuxiaozhen12
Copy link
Contributor

Liuxiaozhen12 commented Nov 19, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 19, 2021

@Liuxiaozhen12: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Liuxiaozhen12
Copy link
Contributor

Liuxiaozhen12 commented Nov 19, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 19, 2021
@Liuxiaozhen12 Liuxiaozhen12 added the needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. label Nov 19, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 23, 2021
@Liuxiaozhen12
Copy link
Contributor

Liuxiaozhen12 commented Nov 24, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 24, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 53356ca

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 24, 2021
@ti-chi-bot ti-chi-bot merged commit bd0ae11 into pingcap:master Nov 24, 2021
@Liuxiaozhen12
Copy link
Contributor

Liuxiaozhen12 commented Nov 24, 2021

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2021
@Liuxiaozhen12 Liuxiaozhen12 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 24, 2021
Merged
9 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 24, 2021

In response to a cherrypick label: new pull request created: #837.

ti-chi-bot added a commit that referenced this pull request Nov 24, 2021
@ti-chi-bot
zh/en: add 5.3.0 release note (#827) (#837)
7f875de
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@lance6716 lance6716 lance6716 left review comments

@glorv glorv glorv left review comments

@Liuxiaozhen12 Liuxiaozhen12 Liuxiaozhen12 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/no-need The changes in this PR don't need to be translated.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Ehco1996 @ti-chi-bot @Liuxiaozhen12 @lance6716 @glorv