Skip to content
This repository was archived by the owner on Jan 3, 2025. It is now read-only.

Conversation

@YiniXu9506
Copy link
Contributor

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Since the structure of TOC.md has been changed, the parse method for generating PDF is failed. This PR is to fix the parse method.

And this issue caused by #831

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.3 (TiDB DM 5.3 versions)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 24, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Liuxiaozhen12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 24, 2021
@Liuxiaozhen12 Liuxiaozhen12 added the translation/no-need The changes in this PR don't need to be translated. label Nov 25, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 25, 2021
@Liuxiaozhen12
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@Liuxiaozhen12: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Liuxiaozhen12
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 25, 2021
@Liuxiaozhen12
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: fe3d3ac

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 25, 2021
@Liuxiaozhen12 Liuxiaozhen12 removed the missing-translation-status This PR does not have translation status info. label Nov 25, 2021
@ti-chi-bot ti-chi-bot merged commit ebb306f into master Nov 25, 2021
@Liuxiaozhen12 Liuxiaozhen12 added needs-cherry-pick-release-1.0 Should cherry pick this PR to release-1.0 branch. needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. labels Nov 25, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #840.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #841.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #842.

@YiniXu9506 YiniXu9506 deleted the scripts/generatePDF branch December 30, 2021 06:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-cherry-pick-release-1.0 Should cherry pick this PR to release-1.0 branch. needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/no-need The changes in this PR don't need to be translated.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants