Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight TiFlash does not support Lightning #5841

Merged
merged 9 commits into from
May 25, 2021
Merged

Highlight TiFlash does not support Lightning #5841

merged 9 commits into from
May 25, 2021

Conversation

flowbehappy
Copy link
Contributor

@flowbehappy flowbehappy commented Mar 25, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

TiFlash does not support Lightning currently. We must explicitly notify the issue.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2021
@flowbehappy
Copy link
Contributor Author

/cc @TomShawn

@ti-chi-bot ti-chi-bot requested a review from TomShawn March 25, 2021 09:00
@flowbehappy
Copy link
Contributor Author

/cc @yikeke

@ti-chi-bot ti-chi-bot requested a review from yikeke March 25, 2021 09:01
@TomShawn
Copy link
Contributor

/cc @kennytm
/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/status PTAL
/translation doing
/assign Joyinqin

@ti-chi-bot ti-chi-bot added the status/PTAL This PR is ready for reviewing. label Mar 25, 2021
@ti-chi-bot ti-chi-bot requested a review from kennytm March 25, 2021 09:03
@ti-chi-bot ti-chi-bot added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-4.0 and removed missing-translation-status This PR does not have translation status info. labels Mar 25, 2021
@flowbehappy flowbehappy mentioned this pull request Mar 25, 2021
Merged
6 tasks
@TomShawn
Copy link
Contributor

/unassign @Joyinqin
/assign @flowbehappy

@ti-chi-bot ti-chi-bot assigned flowbehappy and unassigned Joyinqin Mar 25, 2021
@TomShawn
Copy link
Contributor

/remove-translation doing
/translation done

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 25, 2021
This was referenced Mar 25, 2021
Closed
Closed
@kennytm
Copy link
Contributor

kennytm commented Mar 26, 2021

/lgtm

@ti-chi-bot
Copy link
Member

@kennytm: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

TomShawn commented Apr 6, 2021

/label requires-version-specific-changes

@ti-chi-bot ti-chi-bot added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Apr 6, 2021
@flowbehappy @TomShawn
Update tidb-lightning/tidb-lightning-overview.md
3d9e2f9 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ti-chi-bot
Copy link
Member

@TomShawn: GitHub didn't allow me to request PR reviews from the following users: ilovesoup.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @ilovesoup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TomShawn
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 25, 2021
@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 25, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 61d2794

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2021
@ti-chi-bot ti-chi-bot merged commit 5109166 into pingcap:master May 25, 2021
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request May 25, 2021
@flowbehappy @ti-chi-bot
This is an automated cherry-pick of pingcap#5841
81f9673 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 25, 2021
Merged
6 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6328.

@ti-chi-bot ti-chi-bot mentioned this pull request May 25, 2021
Merged
6 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6329.

This was referenced May 25, 2021
Merged
Merged
ti-chi-bot added a commit that referenced this pull request May 25, 2021
@ti-chi-bot
Highlight TiFlash does not support Lightning (#5841) (#6329)
a7d6225
ti-chi-bot added a commit that referenced this pull request May 25, 2021
@ti-chi-bot
Highlight TiFlash does not support Lightning (#5841) (#6328)
d1e1570
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@kennytm kennytm kennytm left review comments

@ilovesoup ilovesoup ilovesoup approved these changes

Assignees

@flowbehappy flowbehappy

Labels
requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@flowbehappy @TomShawn @kennytm @ti-chi-bot @ilovesoup @Joyinqin