Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight TiFlash does not support Lightning in TiFlash section #5848

Closed
wants to merge 3 commits into from
Closed

Highlight TiFlash does not support Lightning in TiFlash section #5848

wants to merge 3 commits into from

Conversation

flowbehappy
Copy link
Contributor

@flowbehappy flowbehappy commented Mar 25, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

Similar to #5841. Mention it in TiFlash section.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 25, 2021
@flowbehappy flowbehappy mentioned this pull request Mar 25, 2021
Closed
6 tasks
@flowbehappy
Copy link
Contributor Author

/cc @TomShawn

@ti-chi-bot ti-chi-bot requested a review from TomShawn March 25, 2021 10:29
@flowbehappy
Copy link
Contributor Author

/cc @yikeke

@ti-chi-bot ti-chi-bot requested a review from yikeke March 25, 2021 10:30
TomShawn
TomShawn reviewed Mar 25, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@TomShawn
Copy link
Contributor

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/translation done
/size small
/assign @flowbehappy

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. size/small Changes of a small size. needs-cherry-pick-5.0 translation/from-docs This PR is translated from a PR in pingcap/docs. and removed missing-translation-status This PR does not have translation status info. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Mar 25, 2021
@ti-chi-bot
Copy link
Member

@TomShawn: These labels are not set on the issue: translation/done.

In response to this:

/remove-translation done
/translation from-docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

/remove-translation from-docs
/translation done

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/from-docs This PR is translated from a PR in pingcap/docs. labels Mar 25, 2021
This was referenced Mar 25, 2021
Merged
Merged
@TomShawn
Copy link
Contributor

/remove-label needs-cherry-pick-4.0
/remove-label needs-cherry-pick-5.0
/remove-translation done

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. and removed translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-4.0 labels Mar 25, 2021
@TomShawn
Copy link
Contributor

/unassign @flowbehappy

@TomShawn
Copy link
Contributor

/uncc yikeke

@ti-chi-bot ti-chi-bot removed the request for review from yikeke March 25, 2021 11:34
@flowbehappy @TomShawn
Update tiflash/use-tiflash.md
f620cc1 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ti-chi-bot ti-chi-bot removed the size/small Changes of a small size. label Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

Assignees
No one assigned
Labels
missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flowbehappy @ti-chi-bot @TomShawn