Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight TiFlash does not support Lightning #5119

Merged
merged 5 commits into from
May 25, 2021
Merged

Highlight TiFlash does not support Lightning #5119

merged 5 commits into from
May 25, 2021

Conversation

flowbehappy
Copy link
Contributor

What is changed, added or deleted? (Required)

TiFlash does not support Lightning currently. We must explicitly notify the issue.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label Mar 25, 2021
@flowbehappy
Copy link
Contributor Author

/cc @TomShawn

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 25, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn March 25, 2021 09:09
@flowbehappy
Copy link
Contributor Author

/cc @yikeke

@ti-chi-bot ti-chi-bot requested a review from yikeke March 25, 2021 09:09
@flowbehappy flowbehappy mentioned this pull request Mar 25, 2021
Merged
6 tasks
This was referenced Mar 25, 2021
Closed
Closed
@TomShawn
Copy link
Contributor

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-5.0 and removed missing-translation-status This PR does not have translation status info. labels Mar 25, 2021
@TomShawn
Copy link
Contributor

@flowbehappy 建议将 #5122 的内容合并到这个 PR 中来。

@flowbehappy flowbehappy reopened this Mar 26, 2021
@flowbehappy
Copy link
Contributor Author

flowbehappy commented Mar 26, 2021 •
edited
Loading

@flowbehappy 建议将 #5122 的内容合并到这个 PR 中来。

@TomShawn Done.

@yikeke yikeke removed their request for review March 29, 2021 01:39
ilovesoup
ilovesoup approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@ilovesoup ilovesoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Member

@ilovesoup: /lgtm is only allowed for the reviewers in list.

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@flowbehappy @TomShawn
Update tidb-lightning/tidb-lightning-overview.md
d0db6eb 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Contributor

TomShawn commented Apr 6, 2021

/label requires-version-specific-changes

@ti-chi-bot ti-chi-bot added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Apr 6, 2021
@TomShawn
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 25, 2021
@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 25, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 98e95e5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2021
This was referenced May 25, 2021
Merged
Merged
@ti-chi-bot ti-chi-bot merged commit 0490f3b into pingcap:master May 25, 2021
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request May 25, 2021
@flowbehappy @ti-chi-bot
This is an automated cherry-pick of pingcap#5119
44bfb92 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5693.

@ti-chi-bot ti-chi-bot mentioned this pull request May 25, 2021
Merged
6 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5694.

@ti-chi-bot ti-chi-bot mentioned this pull request May 25, 2021
Merged
6 tasks
ti-chi-bot added a commit that referenced this pull request May 25, 2021
@ti-chi-bot
Highlight TiFlash does not support Lightning (#5119) (#5694)
e5332dd
ti-chi-bot added a commit that referenced this pull request May 25, 2021
@ti-chi-bot
Highlight TiFlash does not support Lightning (#5119) (#5693)
29113d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@ilovesoup ilovesoup ilovesoup approved these changes

Assignees
No one assigned
Labels
requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flowbehappy @TomShawn @ti-chi-bot @ilovesoup