-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to TypeScript #401
Comments
Summarizing work so far. It took nearly 3 hours to port all of bending light (8900 lines) to TypeScript. WebStorm tooling provided good support with tooling like "infer types from JSDoc" and "promote to property". The port is not complete due to the following:
I discovered numerous problems in this port so far, like:
|
In the commits, I added type declaration for strings, better enum support and addressed several TODOs. Total time so far: about 9.5 hours. What's left:
Many of the existing problems are due to inadequacies in common code. I can add better types for options, and look through the any and ts-ignore again, but many things may need to wait until we have common code support. |
This port is is good shape and I don't plan other work at the moment. Closing. |
To help move TypeScript forward and to get the benefits of TypeScript in this repo, we should port it to TypeScript.
The text was updated successfully, but these errors were encountered: