Skip to content

Commit

Permalink
Rename drag listener, see #401
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Oct 11, 2021
1 parent 2fccf78 commit 2d8248a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions js/prisms/view/PrismNode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import Prism from '../model/Prism.js';
import PrismsModel from '../model/PrismsModel.js';

class PrismNode extends Node {
movableDragHandler: DragListener;
dragListener: DragListener;
updatePrismShape: () => void;
updatePrismColor: () => void;
translateViewXY: ( x: any, y: any ) => void;
Expand Down Expand Up @@ -94,7 +94,7 @@ class PrismNode extends Node {
prism.translate( inBounds.x - center.x, inBounds.y - center.y );
} );

this.movableDragHandler = new DragListener( { // TODO: Rename, see https://github.com/phetsims/bending-light/issues/372
this.dragListener = new DragListener( {
useParentOffset: true,
positionProperty: prism.positionProperty,

Expand All @@ -117,7 +117,7 @@ class PrismNode extends Node {
} );

if ( !isIcon ) {
prismPathNode.addInputListener( this.movableDragHandler );
prismPathNode.addInputListener( this.dragListener );
}

const knobCenterPoint = new Vector2( -knobNode.getWidth() - 7, -knobNode.getHeight() / 2 - 8 );
Expand Down
2 changes: 1 addition & 1 deletion js/prisms/view/PrismToolboxNode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ class PrismToolboxNode extends Node {
prismLayer.addChild( prismNode );

// @ts-ignore
prismNode.movableDragHandler.press( event, prismNode );
prismNode.dragListener.press( event, prismNode );
} );
prismToolboxIconNode.addInputListener( dragListener );

Expand Down

0 comments on commit 2d8248a

Please sign in to comment.