Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Review: TypeScript port #404

Closed
samreid opened this issue Oct 12, 2021 · 2 comments
Closed

Code Review: TypeScript port #404

samreid opened this issue Oct 12, 2021 · 2 comments
Labels
dev:code-review

Comments

@samreid
Copy link
Member

samreid commented Oct 12, 2021

After porting to TypeScript in #401, I realized it would be great if someone else can code review it. I'm reluctant to ask now since at the last developer meeting, all other developers were still getting up to speed on TypeScript. But I'll mark this as a placeholder and request a review when appropriate.
@samreid samreid self-assigned this Nov 4, 2021
@samreid
Copy link
Member Author

samreid commented Nov 12, 2021

I don't feel like this review is relatively high enough priority at the moment. Maybe this should be reconsidered as we evaluate TypeScript in December.

@samreid samreid removed their assignment Nov 12, 2021
@samreid
Copy link
Member Author

samreid commented Dec 13, 2021

Maybe the best way to proceed is to incorporate TypeScript reviews into our standard reviews, closing.

@samreid samreid closed this as completed Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samreid