Cleanup light client leftovers

[dmitry-markin]

This PR completely deprecates light client mode. Companion to paritytech/substrate#11865

cumulus companion: paritytech/cumulus#1456

[sandreim]

LGTM, we could also be removing these as well:

• node/network/protocol/src/lib.rs

• polkadot/parachain/test-parachains/adder/collator/src/main.rs

  Line 60 in decdbed

  Role::Light => Err("Light client not supported".into()),

• polkadot/parachain/test-parachains/undying/collator/src/main.rs

  Line 60 in decdbed

  Role::Light => Err("Light client not supported".into()),

[dmitry-markin]

@sandreim, thanks, missed test-parachains, fixed.

As for node/network/protocol/src/lib.rs, doesn't ObservedRole represent a self-reported role of the remote node, not us? Which can be reported, i.e., by smoldot Or am I missing something?

[dmitry-markin]

| wasm source files changed or the spec version in the substrate reference in
| the Cargo.lock but not the spec/impl version. If changes made do not alter
| logic, just bump 'impl_version'. If they do change logic, bump
| 'spec_version'.
| 
| source file directories:
| - runtime
| 
| version files: kusama polkadot westend rococo

Could somebody help with this check? No files in runtime directory were changed by the PR, nor the version of substrate in Cargo.lock

[bkchr]

| wasm source files changed or the spec version in the substrate reference in
| the Cargo.lock but not the spec/impl version. If changes made do not alter
| logic, just bump 'impl_version'. If they do change logic, bump
| 'spec_version'.
| 
| source file directories:
| - runtime
| 
| version files: kusama polkadot westend rococo

Could somebody help with this check? No files in runtime directory were changed by the PR, nor the version of substrate in Cargo.lock

You can ignore this

[sandreim]

@sandreim, thanks, missed test-parachains, fixed.

As for node/network/protocol/src/lib.rs, doesn't ObservedRole represent a self-reported role of the remote node, not us? Which can be reported, i.e., by smoldot Or am I missing something?

I think you are correct.

[paritytech-processbot]

Waiting for commit status.

[paritytech-processbot]

Merge cancelled due to error. Error: Response error (status 500 Internal Server Error):

{"error_message":""}