This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
allow re-use and avoid compiling kusama parachain code #5792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't add the tags myself, I am back to being a regular peasant 😓 - the runtime compilation failure appears to be unrelated. |
coderobe
added
A0-please_review
coderobe
approved these changes
Jul 20, 2022
sandreim
approved these changes
Jul 20, 2022
bkchr
approved these changes
Jul 20, 2022
ordian
added a commit
that referenced
this pull request
Jul 22, 2022
* master: westend xcm: collectives parachain is trusted teleporter (#5798) Cleanup light client leftovers (#5794) Fix benchmarking tests (#5791) allow re-use and avoid compiling kusama parachain code (#5792) Introduce async runtime calling trait for runtime-api subsystem (#5782) add `Extrinsic Ordering` check that runs against a local reference node (#5790) Co #11456: Expose `benchmark extrinsic` command (#5620) `staking-miner`: Add handling of `SIGTERM`, `SIGKILL`, `SIGQUIT` and `SIGINT` (#5780) Zombienet: paritydb test (#5310) Fix Typo (#5766) Fix Core Version display in the release notes (#5781) companion for new pools reward scheme (#5757) fix disable-runtime-api feature flag (#5773) split NetworkBridge into two subsystems (#5616) Implement prune only stagnant check mode (#5761)
ordian
added a commit
that referenced
this pull request
Jul 28, 2022
* master: (37 commits) Backport crate version bumps to 0.9.27 (#5826) Fix GHA (#5825) [ci] Add timeout to benchmark jobs (#5822) Parachains db column "migration" (#5797) Companion for #11831 (#5784) [ci] Return production image (#5818) add migration for staking v10 (#5817) Prepare for rust 1.62.1 (#5811) Bump strum to 0.24.1 (#5816) Bump substrate (#5814) Add missing trigger wildcards for some CI workflows (#5812) malus: add `finality_delay` cli flag (#5770) [ci] publish parachain-implementers-guide (#5806) westend xcm: collectives parachain is trusted teleporter (#5798) Cleanup light client leftovers (#5794) Fix benchmarking tests (#5791) allow re-use and avoid compiling kusama parachain code (#5792) Introduce async runtime calling trait for runtime-api subsystem (#5782) add `Extrinsic Ordering` check that runs against a local reference node (#5790) Co #11456: Expose `benchmark extrinsic` command (#5620) ...
drahnr
added a commit
to drahnr/cumulus
that referenced
this pull request
Aug 4, 2022
Let the consumer define by overriding the features for the inner deps as needed. Cargo feature resolution allows this. Ref paritytech/polkadot#5792
paritytech-processbot bot
pushed a commit
to paritytech/cumulus
that referenced
this pull request
Aug 4, 2022
* don't require default features for an API crate Let the consumer define by overriding the features for the inner deps as needed. Cargo feature resolution allows this. Ref paritytech/polkadot#5792 * Update client/relay-chain-inprocess-interface/Cargo.toml Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
jordy25519
pushed a commit
to futureversecom/trn-polkadot
that referenced
this pull request
Aug 5, 2022
* allow re-use and avoid compiling kusama parachain code * fixup removed trailing ; * make it compat with rustfmt +nightly
jordy25519
pushed a commit
to futureversecom/trn-cumulus
that referenced
this pull request
Aug 7, 2022
* don't require default features for an API crate Let the consumer define by overriding the features for the inner deps as needed. Cargo feature resolution allows this. Ref paritytech/polkadot#5792 * Update client/relay-chain-inprocess-interface/Cargo.toml Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When re-using polkadot-cli for a custom collator, having to compile the kusama runtime. This PR adds a new default on feature that enables the test runtime conditionally and allows to use the
cliflat without adding the extra compile time.